[Due for payment 2025-04-23] [$250] Cards - Trying to assign same assigned cards to admin on different workspace showing card list

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.17-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): Applausetester+hjiuyh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

Pre-condition: create 2 workspace with american express direct feed card added

1. Go to https://staging.new.expensify.com/home
2. Go to workspace settings > company card
3. In american express direct feed, tap assign card
4. Note 2 cards are available to assign
5. Assign 2 cards selecting default user (admin)
6. Try to assign the card third time
7. Note no active cards available displayed
8. Now open the second workspace > company card
9. In american express direct feed, tap assign card
10. Try to assign 2 available card displayed to default selected user (admin)

Note : use only default user admin to reproduce the issue

Expected Result:

In the different workspace, when trying to assign same cards to same user (admin), it must show no active cards available.

Actual Result:

"Card already assigned to member on different feed" error is shown when trying to assign same assigned cards to the same user(admin) on different workspace.

Trying to assign the same assigned cards to the same user(admin) on different workspace, is showing cards list instead of showing "no active cards available"

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6778913_1742633263304.Screenrecorder-2025-03-22-13-53-34-588.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021907042981915797896
• Upwork Job ID: 1907042981915797896
• Last Price Increase: 2025-04-08
• Automatic offers:
• ikevin127 | Contributor | 106843865
• allgandalf | Contributor | 106871818

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

@jponikarchuk It looks like the linked video might not be the correct one. Could you please double-check and update it. Thanks!

[jponikarchuk]

@samranahm the video is updated, sorry.

[layacat]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cards - Trying to assign same assigned cards to admin on different workspace showing card list

What is the root cause of that problem?

We only the filtered if the current card feed had assigned card and removed it from the current card, but with different workspaces and the same card, this logic will not work.

App/src/libs/CardUtils.ts

Line 442 in 8deddfa

return Object.fromEntries(Object.entries(customFeedCardsToAssign ?? {}).filter(([cardNumber]) => !assignedCards.includes(cardNumber)));

From the above function we also knew that a assigned card meant, that card has a name (cardName):

App/src/libs/CardUtils.ts

Line 435 in 8deddfa

const assignedCards = Object.values(cards).map((card) => card.cardName);

What changes do you think we should make in order to solve the problem?

We should filter out all the assigned card from different workspaces, once a card get assigned to another person, we shouldn't display them on your card selection screen:

1. Create a function to get all the assigned card of your workspaces, the below is the pseudocode, we can improve it later:

function getAllAssignedCards(allCards: any): string[] {
    const cardNames: string[] = [];

    // Loop through all keys in the object
    for (let key in allCards) {
        // Check if the value is an object and contains a `cardName` property
        if (typeof allCards[key] === 'object') {
            // Iterate over the sub-keys to find the `cardName`
            for (let subKey in allCards[key]) {
                if (allCards[key][subKey]?.cardName) {
                    cardNames.push(allCards[key][subKey].cardName);
                }
            }
        }
    }

    return cardNames;
}

2. Update the logic of getFilteredCardList function to use the all assigned cards instead:

const assignedCards = getAllAssignedCards(allCards);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

I don't think we can write test for this situation.

What alternative solutions did you explore? (Optional)

N/A

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mallenexpensify]

Added Needs Reproduction to see if a C+ can reproduce, if so I'll assign to them then make it External. If not, I'll attempt reproduction.