Limit characters of category is different during creating expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.16-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #57370
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows, Mweb
App Component: Workspace Settings

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to workspace settings
3. Edit existing category with max characters( which is 256)
4. Members must categories all expenses toggle on
5. Try to create an expense with category selected ( select category with max characters)
6. Tap create expense
7. Notice error because maximum characters is 255

Expected Result:

With max characters shown when creating category expense created with the selected category has no error

Actual Result:

Max character during creating category name and creating expense have a different which result an error

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Max character during creating category name and creating expense have a different which result an error

What is the root cause of that problem?

We use CATEGORY_NAME_LIMIT = 256 for the case edit the category name

App/src/pages/workspace/categories/EditCategoryPage.tsx

Lines 39 to 42 in 8ead17b

	} else if ([...newCategoryName].length > CONST.CATEGORY_NAME_LIMIT) {
	// Uses the spread syntax to count the number of Unicode code points instead of the number of UTF-16 code units.
	errors.categoryName = translate('common.error.characterLimitExceedCounter', {length: [...newCategoryName].length, limit: CONST.CATEGORY_NAME_LIMIT});
	}

What changes do you think we should make in order to solve the problem?

We should use API_TRANSACTION_CATEGORY_MAX_LENGTH=255 like we did with creating a new category

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[eVoloshchak]

This is a regression caused by #57370
@nkdengineer, could you look into this please?

[nkdengineer]

I'll raise a follow up PR soon