[Due for payment 2025-04-08] [$250] mweb-Incorrect navigation to confirm details page& discard changes popup briefly visible

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.13-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): Slottwo1+55555d@gmail.com
Issue reported by: Applause Internal Team
Device used: Redmi Note 10s android 13
App Component: Money Requests

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open a Workspace chat
3. Tap plus icon> Create expense
4. Enter amount & tap next
5. Tap merchant
6. Enter a text
7. Tap top app's left arrow
8. Note Discard changes pop up box is displayed
9. Tap device back button

Expected Result:

On tapping the device back button from the merchant page, the discard changes popup should close, and the user should remain on the merchant page without navigating to the confirm details page.

Actual Result:

On tapping the device back button from the merchant page, the user is navigated to the confirm details page, and the discard changes popup is briefly visible before disappearing.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6770246_1741920746398.Screenrecorder-2025-03-14-08-19-06-113.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021901567534484541213
• Upwork Job ID: 1901567534484541213
• Last Price Increase: 2025-03-17
• Automatic offers:
• daledah | Contributor | 106586882

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-14 08:58:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

On tapping the device back button from the merchant page, the user is navigated to the confirm details page, and the discard changes popup is briefly visible before disappearing.

What is the root cause of that problem?

In this modal, the Modal component doesn’t use the shouldHandleNavigationBack prop. This prop, implemented here, ensures that when the modal isn't treated as a full screen, the back button dismisses the modal rather than navigating to the previous screen.

Without this prop, pressing the device back button incorrectly navigates to the confirmation details page instead of closing the modal.

What changes do you think we should make in order to solve the problem?

We should enable shouldHandleNavigationBack in:

App/src/pages/iou/request/step/DiscardChangesConfirmation.tsx

Line 33 in ba6abb8

<ConfirmModal

And pass it down to the modal in:

App/src/components/ConfirmModal.tsx

Line 153 in ba6abb8

<Modal

We can either:

• Apply this conditionally (e.g., create a flag or enable it only on mWeb Chrome), or
• Always set shouldHandleNavigationBack to true for consistency.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[kadiealexander]

Android <> iOS bug swap

[jliexpensify]

@daledah @mitarachim can either of you help me understand the issue here? I see the discard changes box appear, but I need to either cancel or accept the discarded changes to get rid of it. To me, this seems like intended behaviour?

I'm using a Pixel 7 btw.

[daledah]

but I need to either cancel or accept the discarded changes to get rid of it

Yes, that’s the intended behavior. However, the bug in this case is that when the discard changes dialog appears, tapping the device back button (step 9) navigates the user back to the confirmation page. The expected behavior is that it should dismiss the discard changes dialog instead.

[jliexpensify]

Got it - thanks! This sounds like device-specific behaviour reported by Applause...does your solution fix this for all Android phones?

The expected behavior is that it should dismiss the discard changes dialog instead.

This is what I'm currently seeing on the Pixel on V9.13-0

the bug in this case is that when the discard changes dialog appears, tapping the device back button (step 9) navigates the user back to the confirmation page.

So I'm not seeing this bug, which explains my confusion!

[daledah]

This is what I'm currently seeing on the Pixel on V9.13-0

But, which platform are you testing? Mweb Chrome or android native?

[mitarachim]

Hello @jliexpensify , +1 with @daledah after tapping the device back button (step 9) navigates the user back to the confirmation page and discard changes popup is briefly visible before disappearing.

mWeb/Chrome. :

2025-03-17.4.27.13.PM.mp4

QA team didn't sure about expected behavior here, but we have expectations with after step 9, discard changes popup should close and the user should remain on the merchant page without navigating to the confirm details page.

[jliexpensify]

Ah sorry, I was testing native - but my mweb is only 9.1.12-3?

[mitarachim]

i'm using mWeb/chrome 9.1.13-5 to reproduce issue