[Awaiting checklist] [$250] Thread - Thread header shows skeleton, message is empty when parent message is deleted

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+3408349@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Chat Report View

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat.
3. Send a message.
4. Right click on the message > Reply in thread.
5. Right click on the parent message > Delete comment.
6. Delete the comment.

Expected Result:

• Thread header in chat report view and LHN will show "Deleted comment".
• The deleted comment will show "Deleted comment".

Actual Result:

• Thread header in chat report view shows skeleton.
• Thread title in LHN shows Hidden.
• The deleted comment is empty with (edited) label.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6766813_1741651828851.thread.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021900900424719200581
• Upwork Job ID: 1900900424719200581
• Last Price Increase: 2025-03-15
• Automatic offers:
• nkdengineer | Contributor | 106601494

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread header in chat report view shows skeleton.
Thread title in LHN shows Hidden.
The deleted comment is empty with (edited) label.

What is the root cause of that problem?

After deleting the parent message, the chat is empty and we don't have the logic to go back to the previous chat, so we can see the skeleton in the header (the report is deleted and never loaded)

What changes do you think we should make in order to solve the problem?

We should add the logic to handle this case in

App/src/libs/actions/Report.ts

Line 1727 in ef00a61

}

else if(Navigation.isActiveRoute(ROUTES.REPORT_WITH_ID.getRoute(reportAction.childReportID)) && !isDeletedParentAction){
       Navigation.setShouldPopAllStateOnUP(true);
        Navigation.goBack(undefined, {shouldPopToTop: true});
    }

We also can use ROUTES.REPORT_WITH_ID.getRoute(reportID) as fallback url or use navigateToMostRecentReport

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can write the test to mimic this case in tests/ui, simulate this case then verify the parent chat is shown at the end

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021900900424719200581

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[kaushiktd]

Please re-state the problem that we are trying to solve in this issue.

Thread header shows skeleton, message is empty when parent message is deleted

What is the root cause of that problem?

The root cause of the issue lies in the navigation logic that handles the transition after deleting a parent message.

The original implementation only checks if the parent route is active and navigates back to the parent report

App/src/libs/actions/Report.ts

Line 1725 in ef00a61

if (Navigation.isActiveRoute(ROUTES.REPORT_WITH_ID.getRoute(reportID, reportActionID)) && !isDeletedParentAction) {

What changes do you think we should make in order to solve the problem?

To address this issue, we updated the logic to handle both the parent and child routes. The conditions to check whether either the parent or the child route is active before navigating back to the parent report.

     const isActiveRoute = Navigation.isActiveRoute(ROUTES.REPORT_WITH_ID.getRoute(reportID, reportActionID)) || 
     Navigation.isActiveRoute(ROUTES.REPORT_WITH_ID.getRoute(reportAction.childReportID));
 
 if (isActiveRoute && !isDeletedParentAction) {
 Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(reportID));
 }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

N/A

video:-

screen-capture.webm