[Due for payment 2025-05-14] [$250] Update the 'Share with accountant' flow to invite the accountant as an admin to the workspace, not just the workspace chat

[thienlnam]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C06ML6X0W9L/p1740097131081729

Action Performed:

1. Track an expense to your self-DM
2. Click 'Share it with my accountant' and share it to one of your workspaces
3. Enter a random email (accountant email)

Expected Result:

The accountant should be added as an admin to the workspace instead

Actual Result:

The accountant is shared the workspace chat

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021897069865349874499
• Upwork Job ID: 1897069865349874499
• Last Price Increase: 2025-03-11

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021897069865349874499

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[s77rt]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-13 02:17:09 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accountant is not added to workspace where he should be added as an admin

What is the root cause of that problem?

Feature request / Flow change

What changes do you think we should make in order to solve the problem?

1. Remove the current logic that invites the accountant to the expense report i.e. in RoomInvitePage and its correspending navigation part.
2. Create a new page IOURequestStepAccountant (this is going to be similar to IOURequestStepParticipants / IOURequestStepAttendees) where we set a new field accountant to the transaction draft.
3. Update createDraftTransactionAndNavigateToParticipantSelector (which is the function that we call after pressing share with accountant) to navigate to the accountant selection page.
4. In IOURequestStepConfirmation pass the transaction accountant field so that we can pass it further to the ShareTrackedExpense API command.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

1. After the expense is shared with an accountant, check policy onyx data and verify that the accountant is an admin.

What alternative solutions did you explore? (Optional)

None

[sobitneupane]

Thanks for the proposal @s77rt.

Could you please add more details to your proposal, specifying what changes are required and where they will be made?

This solution won't implicitly invite the accountant is an admin, instead the user is given the choice to choose the role.

Is this the same behavior as when we invite someone as an admin from WS > Members > Invite Member?

Unlike the room invitation flow, the accountant won't get notified about the expense report and no GBR is displayed.

Could you please clarify the second point? As an admin, the user will have access to the reports, and I believe GBR is displayed.

[s77rt]

👋 @sobitneupane

Could you please add more details to your proposal, specifying what changes are required and where they will be made?

The main change is straightforward as just changing the navigation route to the workspace invite instead of room invite. The change should be made here

App/src/libs/actions/IOU.ts

Line 5084 in da2fa62

Navigation.setNavigationActionToMicrotaskQueue(() => Navigation.navigate(ROUTES.ROOM_INVITE.getRoute(activeReportID, CONST.IOU.SHARE.ROLE.ACCOUNTANT)));

Is this the same behavior as when we invite someone as an admin from WS > Members > Invite Member?

Yes, in fact we are going to use the WS > Members > Invite Member page itself.

Could you please clarify the second point? As an admin, the user will have access to the reports, and I believe GBR is displayed.

When the accountant is invited to the room he will be tagged thus a GBR will be displayed. However if the accountant is added through the WS members flow he won't be tagged on the expense report and no GBR will be displayed (he can access the reports though).

[melvin-bot]

@sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!