[HOLD for payment 2021-12-06] Add app download links to workspace invitation validation email - Reported by: @akshayasalvi

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Invite a new user account (that you have access to) to a workspace
2. Check the validation email

Expected Result:

If the apps are mentioned in the email there should be a download link for iOS and Android.

Actual Result:

Apps are mentioned in email but no download link is included.

Workaround:

None needed.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.7-3

Reproducible in staging?: yes
Reproducible in production?: yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @akshayasalvi
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1633983814141300

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[akshayasalvi]

Proposed Solution

Would want to know the preferences, but if it is going to be plain simple links. We can update the links in the es.js and en.js

en: {
  welcomeNote: ({workspaceName}) => `You have been invited to ${workspaceName}! Download the Expensify mobile app to start tracking your expenses. <a href='${androidUrl}'>Android</a>, <a href='${iosUrl}'>iOS</a>, <a href='${desktopUrl}'>Desktop</a>`
}

In WorkspaceInvitePage,

getWelcomeNotePlaceholder() {
        return this.props.translate('workspace.invite.welcomeNote', {
            workspaceName: this.props.policy.name,
            androidUrl:  CONST.APP_DOWNLOAD_LINKS.ANDROID,
            iosUrl: CONST.APP_DOWNLOAD_LINKS.IOS,
            desktopUrl: CONST.APP_DOWNLOAD_LINKS.DESKTOP,
        });
    }

Guessing we change to modify the content a bit to make it more reader-friendly.

Can implement the same by passing an array of links instead of hardcoding the platforms in the string. (Might be an overkill unnecessarily.)

[MitchExpensify]

Will get to this tomorrow, focusing on N6 right now

[MelvinBot]

@MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!