[Awaiting checklist] [$250] Android - Expense - System message of paid expense, is blacked out when turning internet off

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.7-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+328@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Prerequisite: Delayed submissions and approvals disabled

1. Open the Expensify app
2. Open any workspace chat
3. Tap on "+" button and select "Create Expense"
4. Complete the creation flow
5. Open the just created expense report
6. Tap on "Pay Elsewhere"
7. Tap on header and select "Cancel payment"
8. Return to report and edit any field of the expense
9. Pay the expense again and cancel the payment one more time
10. Return to expense report again and turn internet connection off
11. Scroll down and check the behaviour of the system messages in thread

Expected Result:

System messages generated with the actions on expense report, shouldn´t be blacked out when internet connection is lost

Actual Result:

System messages about the expense being paid, on expense report, are displayed blacked out when internet connection is off

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6757580_1740753012934.Opacity.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021897335589821678403
• Upwork Job ID: 1897335589821678403
• Last Price Increase: 2025-03-05
• Automatic offers:
• FitseTLT | Contributor | 106414870

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-28 14:55:41 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Expense - System message of paid expense, is blacked out when turning internet off

What is the root cause of that problem?

We forgot to reset (on successData) the add pending action on the system message action added optimistically here

App/src/libs/actions/IOU.ts

Lines 7916 to 7924 in 0a8e7aa

	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReport?.reportID}`,
	value: {
	[optimisticIOUReportAction.reportActionID]: {
	...(optimisticIOUReportAction as OnyxTypes.ReportAction),
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	},
	},
	},

What changes do you think we should make in order to solve the problem?

We need to reset the pending action of the iou action optimistically created on successData (and also failureData if needed)
We also need to reset the pending action on failureData for cancel payment if needed

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add a test on payMoneyRequest to assert that the new payed iou action created for the expense report will have the pending action reset on success of the API.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

[twisterdotcom]

Okay, so the point is that some messages are greyed out and some aren't:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021897335589821678403

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)