[$250] WS selector - Forward button doesn't persist the workspace selector filter

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.7-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): testpayment935+926@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Samsung s10/ Chrome
App Component: Other

Action Performed:

Precondition: Have at least one WS

1. Navigate to https://staging.new.expensify.com
2. Click on the workspace selector on the LHN
3. Select created WS
4. Click back button of the browser (located top left)
5. Notice All WS list shown
6. Click forward button of the browser

Expected Result:

The selected WS is shown as the user clicked Back then forward

Actual Result:

The WS filter is not reversed
Previously selected WS is no longer available
Only occur between single workspace and all expensify option (WS to WS works fine)

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6757077_1740705508629.bandicam_2025-02-28_03-59-59-469.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021896496600432582110
• Upwork Job ID: 1896496600432582110
• Last Price Increase: 2025-03-03

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The WS filter is not reversed
Previously selected WS is no longer available
Only occur between single workspace and all expensify option (WS to WS works fine)

What is the root cause of that problem?

When we click on the forward button, activeWorkspaceID is changed from undefined to a policyID. And the activeWorkspace will be undefined briefly because the key is changed, there are some pending merge values of this key and activeWorkspace of the previous key (activeWorkspaceID is undefined) is undefined.

App/src/pages/home/sidebar/BaseSidebarScreen.tsx

Lines 29 to 32 in 7bda731

	const {activeWorkspaceID} = useActiveWorkspace();
	const {translate} = useLocalize();
	const {shouldUseNarrowLayout} = useResponsiveLayout();
	const [activeWorkspace, activeWorkspaceResult] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${activeWorkspaceID ?? CONST.DEFAULT_NUMBER_ID}`);

Then in this useEffect, we call replaceWithSplitNavigator with reportsSplitNavigatorWithoutPolicyID. As a result, the WS filter is changed to all expensify.

App/src/pages/home/sidebar/BaseSidebarScreen.tsx

Lines 42 to 63 in 7bda731

	if (!!activeWorkspace || activeWorkspaceID === undefined || isLoading) {
	return;
	}
	// Otherwise, if the workspace is already loaded, we don't need to do anything
	const topmostReport = getTopmostReportsSplitNavigator();
	if (!topmostReport) {
	return;
	}
	// Switching workspace to global should only be performed from the currently opened sidebar screen
	const topmostReportState = topmostReport?.state ?? getPreservedSplitNavigatorState(topmostReport?.key);
	const isCurrentSidebar = topmostReportState?.routes.some((route) => currentRoute.key === route.key);
	if (!isCurrentSidebar) {
	return;
	}
	const reportsSplitNavigatorWithoutPolicyID = getInitialSplitNavigatorState({name: SCREENS.HOME}, {name: SCREENS.REPORT});
	Navigation.replaceWithSplitNavigator(reportsSplitNavigatorWithoutPolicyID);
	updateLastAccessedWorkspace(undefined);

What changes do you think we should make in order to solve the problem?

We can get the activeWorkspace from all policies instead

const [policies, policiesResult] = useOnyx(ONYXKEYS.COLLECTION.POLICY);
const activeWorkspace = policies?.[`${ONYXKEYS.COLLECTION.POLICY}${activeWorkspaceID}`]

App/src/pages/home/sidebar/BaseSidebarScreen.tsx

Lines 29 to 32 in 7bda731

	const {activeWorkspaceID} = useActiveWorkspace();
	const {translate} = useLocalize();
	const {shouldUseNarrowLayout} = useResponsiveLayout();
	const [activeWorkspace, activeWorkspaceResult] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${activeWorkspaceID ?? CONST.DEFAULT_NUMBER_ID}`);

OPTIONAL: We can also reduce the activeWorkspace dependency by creating a new boolean variable and replace activeWorkspace with this variable. We can also check the activeWorkspace is valid or not with shouldShowPolicy function.

App/src/pages/home/sidebar/BaseSidebarScreen.tsx

Lines 42 to 63 in 7bda731

	if (!!activeWorkspace || activeWorkspaceID === undefined || isLoading) {
	return;
	}
	// Otherwise, if the workspace is already loaded, we don't need to do anything
	const topmostReport = getTopmostReportsSplitNavigator();
	if (!topmostReport) {
	return;
	}
	// Switching workspace to global should only be performed from the currently opened sidebar screen
	const topmostReportState = topmostReport?.state ?? getPreservedSplitNavigatorState(topmostReport?.key);
	const isCurrentSidebar = topmostReportState?.routes.some((route) => currentRoute.key === route.key);
	if (!isCurrentSidebar) {
	return;
	}
	const reportsSplitNavigatorWithoutPolicyID = getInitialSplitNavigatorState({name: SCREENS.HOME}, {name: SCREENS.REPORT});
	Navigation.replaceWithSplitNavigator(reportsSplitNavigatorWithoutPolicyID);
	updateLastAccessedWorkspace(undefined);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021896496600432582110

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)