[Due for payment 2025-03-17] [$250] No RBR in the report shown immediately when deleting selected rate

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.7-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #57448
Email or phone of affected tester (no customers): testpayment935+fd@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Samsung s10/ Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

Precondition:
The Distance Rates feature is enabled.
There are multiple distance rates, including a default distance rate.

1. Navigate to https://staging.new.expensify.com
2. Navigate to the Workspace Chat, select a distance rate, and create a distance request.
3. Delete the distance rate that is selected above
4. Go to the Workspace chat and notice there is no RBR in WS LHN and the report
5. Go to the transaction detail and notice there is an error and RBR shown in WS LHN and report

Expected Result:

RBR should be shown instantly in WS after deleting rate

Actual Result:

The RBR only appears after navigating to combined expense report /expense report

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6757000_1740697799787.bandicam_2025-02-28_01-51-47-182.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021895549840763723230
• Upwork Job ID: 1895549840763723230
• Last Price Increase: 2025-02-28
• Automatic offers:
• paultsimura | Reviewer | 106367118
• daledah | Contributor | 106367122

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The RBR only appears after navigating to combined expense report /expense report

What is the root cause of that problem?

When deleting a distance rate, we don't have logics to modify transaction violations, so the RBR is not displayed. Transaction violation data only appear after opening the transaction report

What changes do you think we should make in order to solve the problem?

We should add optimistic transaction violation data when deleting the distance rate:

App/src/libs/actions/Policy/DistanceRate.ts

Line 484 in 7bda731

function deletePolicyDistanceRates(policyID: string, customUnit: CustomUnit, rateIDsToDelete: string[]) {

1. Create allTransactions and transactionViolations Onyx value
2. Create optimistic data

const transactions = Object.values(allTransactions ?? {}).filter((transaction) => transaction?.comment?.customUnit?.customUnitID === customUnit.customUnitID);
const optimisticTransactionsViolations: OnyxUpdate[] = [];

transactions.forEach((transaction) => {
        const currentTransactionViolations = transactionViolations?.[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction?.transactionID}`] ?? [];
        if (currentTransactionViolations.find((violation) => violation.name === CONST.VIOLATIONS.CUSTOM_UNIT_OUT_OF_POLICY)) {
            return;
        }
        optimisticTransactionsViolations.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction?.transactionID}`,
            value: [
                ...currentTransactionViolations,
                {
                    type: CONST.VIOLATION_TYPES.VIOLATION,
                    name: CONST.VIOLATIONS.CUSTOM_UNIT_OUT_OF_POLICY,
                    showInReview: true, // this value is to be discussed further
                },
            ],
        });
    });

3. And failure data

const failureTransactionsViolations: OnyxUpdate[] = transactions.map((transaction) => {
        const currentTransactionViolations = transactionViolations?.[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction?.transactionID}`];
        return {onyxMethod: Onyx.METHOD.MERGE, key: `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction?.transactionID}`, value: currentTransactionViolations};
    });

POC

Screen.Recording.2025-02-28.at.10.49.05.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021895549840763723230

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[paultsimura]

The proposal by @daledah looks good to me.

🎀👀🎀 C+ reviewed

For the assigned Engineer: should we also consider adding this violation calculation to the BE logic of DeletePolicyDistanceRates request to be consistent with the new optimistic data?