[Due for payment 2025-04-10] [$250] `Get Started here` tooltip is shown twice in LHN on an account which has existing merged account.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.1-0 - dev
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Login with new account A on the OldDot, new login with another new account B on NewDot. Do not complete Onboarding.
2. On OldDot, logout from Account A and Login with Account B.
3. If you are redirected to NewDot from OldDot, then clear all cookies for OldDot and NewDot.
4. Now, merge Account A into Account B.
5. Now login in NewDot with Account B. Follow steps to see get Started here tooltip if following steps does not work.
6. Complete Onboarding by selecting something else purpose.
7. Check the Get Started here tooltip on LHN both Concierge chat.

Expected Result:

Only active Concierge chat shows get Started here in LHN.

Actual Result:

Both Active and archived concierge chat in LHN show Get Started here tooltip.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021895516702945906533
• Upwork Job ID: 1895516702945906533
• Last Price Increase: 2025-03-07

Issue Owner

Current Issue Owner: @greg-schroeder

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

Proposal by @parasharrajat

Proposal

Please re-state the problem that we are trying to solve in this issue.

Two Get Started here tooltips are shown to the user when they have two concierge chat.

What is the root cause of that problem?

An account where another account has been merged, can have two concierge chats. Where one is archived one. Because we only check of concierge report and don't check for archived status, two will show both chats in LHN.

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 67 in 11302a9

const shouldShowGetStartedTooltip = isOnboardingGuideAssigned ? isAdminRoom(report) && isChatUsedForOnboarding : isConciergeChatReport(report);

.

We didn't check for archived in here.

App/src/libs/ReportUtils.ts

Line 1545 in 11302a9

function isConciergeChatReport(report: OnyxInputOrEntry<Report>): boolean {

What changes do you think we should make in order to solve the problem?

1. We should update this function to exclude archived chats.

js
function isConciergeChatReport(report: OnyxInputOrEntry): boolean {
if (!report?.participants || isThread(report) || isArchivedReportWithID(report?.reportID)) {
return false;
}
2. Carefully check if we need need access to archived Concierge chat. If yes, then instead of directly exclude the archived chat, do it behind a parameter.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None. But happy to update if needed.

What alternative solutions did you explore? (Optional)

1. We can drop checking the participants to determine the concierge chat instead solely depend on the report?.reportID === conciergeChatReportID check in following function where conciergeChatReportID is coming from ONYXKEYS.CONCIERGE_REPORT_ID Onyx Value.

App/src/libs/ReportUtils.ts

Line 1545 in 11302a9

function isConciergeChatReport(report: OnyxInputOrEntry<Report>): boolean {

[shubham1206agra]

This is related to Merge Account Project #54443. This should be handled by @parasharrajat and @allroundexperts as part of the same project.

cc @arosiclair @mallenexpensify

[parasharrajat]

Its not related. It's a pre-existing bug. On the Merge feature project, we are working on adding merge account functionality. This bug is around current onboarding.

[shubham1206agra]

Hmmm, I think it falls under the project as per your RCA

An account where another account has been merged, can have two concierge chats. Where one is archived one. Because we only check of concierge report and don't check for archived status, two will show both chats in LHN.

This case should be covered in merge account project. Since before this project, it's not really impacting any user. I would suggest holding this issue for project completion and then we could proceed.

[parasharrajat]

It impacted a real user onboarding. Thus, I found it while working on that issue. We recorded the error on Fullstory.

But it's fine. We can handle this parellely. Don't worry.

[arosiclair]

Its not related. It's a pre-existing bug. On the Merge feature project, we are working on adding merge account functionality. This bug is around current onboarding.

Yup this is correct. Pre-existing merge bugs are not in scope for the Merge Accounts project.