[Due for payment 2025-03-13] [$250] Reports - Rename search page is reopened after saving a search and using device back button.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.5-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+305@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Search

Action Performed:

1. Open the Expensify app.
2. Tap on "Reports" on the bottom of the screen.
3. Tap on the filters icon.
4. Apply any filter and save the search.
5. Tap on "Cancel"
6. Tap on the bookmark icon.
7. Tap on the three dots icon on the saved search and select "Rename"
8. Edit the search name and save the new name.
9. Tap on "Cancel"
10. Use device´s back button.

Expected Result:

After saving the new name of a search, landing on "Reports" and using device´s back button, the rename search page shouldn´t be reopened.

Actual Result:

Rename search page is reopened instead of inbox, after the user saves a new name, lands on "Reports" and uses device´s back button.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6753276_1740456958889.Save.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021894396612887094597
• Upwork Job ID: 1894396612887094597
• Last Price Increase: 2025-02-25
• Automatic offers:
• nkdengineer | Contributor | 106279877

Issue Owner

Current Issue Owner: @maddylewis

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Rename search page is reopened instead of inbox, after the user saves a new name, lands on "Reports" and uses device´s back button.

What is the root cause of that problem?

We do two navigation actions here without waiting until the first one is complete then it doesn't work as expected and we also can see the console error appears

App/src/pages/Search/SavedSearchRenamePage.tsx

Lines 28 to 35 in eaa3be4

	Navigation.dismissModal();
	Navigation.navigate(
	ROUTES.SEARCH_ROOT.getRoute({
	query: q,
	name: newName?.trim(),
	}),
	);
	};

What changes do you think we should make in order to solve the problem?

We need to use Navigation.isNavigationReady for the second navigation action to wait for the dismiss action is complete

Navigation.dismissModal();
Navigation.isNavigationReady().then(() => {
    Navigation.navigate(
        ROUTES.SEARCH_ROOT.getRoute({
            query: q,
            name: newName?.trim(),
        }),
    );
});

App/src/pages/Search/SavedSearchRenamePage.tsx

Lines 28 to 35 in eaa3be4

	Navigation.dismissModal();
	Navigation.navigate(
	ROUTES.SEARCH_ROOT.getRoute({
	query: q,
	name: newName?.trim(),
	}),
	);
	};

or using InteractionManager.runAfterInteraction

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

We can only use goBack and remove both navigation actions here

Navigation.goBack(
    ROUTES.SEARCH_ROOT.getRoute({
        query: q,
        name: newName?.trim(),
    }),
);

App/src/pages/Search/SavedSearchRenamePage.tsx

Lines 28 to 35 in eaa3be4

	Navigation.dismissModal();
	Navigation.navigate(
	ROUTES.SEARCH_ROOT.getRoute({
	query: q,
	name: newName?.trim(),
	}),
	);
	};

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021894396612887094597

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[dukenv0307]

@nkdengineer's proposal looks good to me

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

LGMT2!