[Due for payment 2025-03-17] [Due for payment 2025-03-13] [$250] iOS - Search - Search page cannot be dismissed by swiping to the right

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.4-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Search

Action Performed:

1. Launch ND or hybrid app.
2. Tap on the search icon on the top right
3. Swipe to the right to dismiss the search page (iOS swiping style)

Expected Result:

The search page can be dismissed by swiping to the right (previously it was fixed in #51731)

Actual Result:

The search page cannot be dismissed by swiping to the right.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6750749_1740219577904.20250222_181417.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021894676272056100014
• Upwork Job ID: 1894676272056100014
• Last Price Increase: 2025-02-26
• Automatic offers:
• DylanDylann | Reviewer | 106292983
• nkdengineer | Contributor | 106292984

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-22 20:02:26 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The search page cannot be dismissed by swiping to the right.

What is the root cause of that problem?

It starts to happen after this PR, we removed swipeDirection that returned from getModalStyles and replaced it with swipeDirection prop

https://github.com/Expensify/App/pull/55157/files#diff-c5dd0a065b12f253786ab2916473640a80014957475696db4d97bedc23f47af2L158

App/src/components/Modal/BaseModal.tsx

Line 76 in 0b6d1a0

swipeDirection,

And we don't pass swipeDirection prop here.

App/src/components/Search/SearchRouter/SearchRouterModal.tsx

Line 22 in 0b6d1a0

<Modal

It may aslo happen with other modal that has propagateSwipe is true

What changes do you think we should make in order to solve the problem?

Pass the swipeDirection as right here. We need to check for other places that propagateSwipe is true and pass swipeDirection prop accordingly if it happens

App/src/components/Search/SearchRouter/SearchRouterModal.tsx

Line 22 in 0b6d1a0

<Modal

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

It's just missing a prop for swipe action so I think we can skip the test

What alternative solutions did you explore? (Optional)

We can still get the swipeDirection from getModalStyles and fallback it here if swipeDirection prop is undefined

App/src/components/Modal/BaseModal.tsx

Line 187 in 0b6d1a0

StyleUtils.getModalStyles(

Or we can add the default value for swipeDirection

Or we can remove swipeDirection prop and still get swipeDirection from getModalStyles because I don't see we pass this prop anywhere

Result

Screen.Recording.2025-02-23.at.02.58.28.mov

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021894676272056100014

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[JmillsExpensify]

Opened up to the community