[Due for payment 2025-03-31] [$250] Web - Onboarding-User lands on the admins room after selecting the Manage my team's expenses

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.2-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: Applause Internal Team
Device used: Mac 15.2/Safari
App Component: Other

Action Performed:

1. Open the app
2. Create a new user with a new email with a '+' in it.
   3.Select the option "Manage my team's expenses"
   4.Select any option in the "How many employees do you have?" modal and click continue
   5.Select any option in the "Do you use any accounting software?" modal and click continue

Expected Result:

Selecting "Manage my team's expenses",the user lands on the concierge conversation and it's scrolled to the bottom

Actual Result:

The user lands on the admins room after selecting the Manage my team's expenses. After switching to another conversation, the admins room disappears.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6748742_1740036836107.Recording__642.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021895067744665816136
• Upwork Job ID: 1895067744665816136
• Last Price Increase: 2025-03-11
• Automatic offers:
• dominictb | Reviewer | 106516846
• daledah | Contributor | 106516847

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[laurenreidexpensify]

@amyevans is this related to the changes you're working on by any chance?

[Shahidullah-Muffakir]

This is the expected behavior because:

1. Tasks are now created in the Admin Room instead of the Concierge chat, so the user should land in the Admin Room. Related fix: app does not open admin room after onboarding #55654
2. The reason tasks are not appearing in the Admin Room but are instead showing in the Concierge chat (as seen in the video shared in the OP) is that the test account used has an alias (+ in the email).
   

   App/src/libs/actions/Report.ts

   Lines 3656 to 3658 in 61f2d50

   	const shouldPostTasksInAdminsRoom =
   	[CONST.ONBOARDING_CHOICES.MANAGE_TEAM, CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE].includes(engagementChoice as PostTasksInAdminsRoomOnboardingChoices) &&
   	!currentUserEmail?.includes('+');

[Shahidullah-Muffakir]

However, if we want to correct this for test accounts that have a + in their email, we can conditionally redirect them to the Concierge chat.
We can update this:

App/src/libs/navigateAfterOnboarding.ts

Lines 18 to 23 in 61f2d50

	if (!isSmallScreenWidth) {
	if (onboardingAdminsChatReportID) {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingAdminsChatReportID));
	}
	return;
	}

    if (!isSmallScreenWidth) {
        if (onboardingAdminsChatReportID && !currentUserEmail?.includes('+')) {
            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingAdminsChatReportID));
        }
        return;
    }

[amyevans]

@amyevans is this related to the changes you're working on by any chance?

Not related, but happy to provide input if needed nonetheless!

However, if we want to correct this for test accounts that have a + in their email, we can conditionally redirect them to the Concierge chat.

I don't think we care enough to change this, we should just update the TC with the new expected behavior, but I defer to @laurenreidexpensify if she thinks otherwise!

[melvin-bot]

@amyevans, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@amyevans, @laurenreidexpensify Huh... This is 4 days overdue. Who can take care of this?