[Due for payment 2025-03-11] [Due for payment 2025-03-10] Follow ups to Broken Connection with direct feeds

[mountiny]

Problem

Coming from here:

BUG: We're showing mark as cash button with violation on approved reports. It is correct that we show members the violation on approved/paid reports, but there should be no option to mark as cash in those report states.

And from here https://expensify.slack.com/archives/C07HPDRELLD/p1739989158015199

BUG: Admins don't see this violation on their own expenses, or other employees. They are supposed to see it on both. The expense preview have red dots, but no violation appears when you click in. 🧵

Also coming from here - waiting for copy confirmation

BUG: Violation copy differs for open vs processing reports. Specifically, processing is missing copy about marking as cash. 🧵

Solution

Discussed in the threads, this should be fixable in FE cc @VickyStash

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[VickyStash]

UPD: I haven't had a lot of time on this issue today, but I was able to prepare the accounts for testing and debugging with broken connection violations. Hope to focus tomorrow on bug fixes.

[VickyStash]

Updates:

• I've fixed all of the reported issues. Opened Draft PR, added Test steps and part of the screenshots.
• During testing I've noticed one small issue, waiting for the confirmation about the way it should be resolved - fixed.

I think the PR will be ready for the review on Monday!