[Due for payment 2025-04-16] [$250] Chat - Dismissing wrong message link error disappears the chat from LHN

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.1-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): vdargentotest+web021925@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, iOS 18.3.1 / iPhone 13
App Component: Other

Action Performed:

1. Go to any chat
2. Send a message
3. Right-click on the message and select "Copy link"
4. Go any other chat
5. Paste the link in compose box but delete a few last characters
6. Click on the link you sent
7. Verify in takes you to Not here page and that the first chat has a RBR in the LHN
8. Click on the hyperlink in the Not here page
9. Verify it takes you to the first chat and you see an error
10. Dismiss the error by clicking in the "x"
11. Verify the chat disappears from the LHN
12. Click on the search button
13. Verify the chat it's not displayed until it is manually searched

Expected Result:

The chat should not disappear after dismissing the error

Actual Result:

The chat disappears after dismissing the error, searching is needed for it to reappear

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6747984_1739976689929.bandicam_2025-02-19_10-27-33-611.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021894711298971649891
• Upwork Job ID: 1894711298971649891
• Last Price Increase: 2025-03-12
• Automatic offers:
• allgandalf | Reviewer | 106557644
• FitseTLT | Contributor | 106557646

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-19 15:55:25 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Dismissing wrong message link error disappears the chat from LHN

What is the root cause of that problem?

When opening linked action with wrong link the backend returns createChat error and on dismissing the error we navigate to concierge chat and delete the report here

App/src/pages/home/report/ReportActionItemCreated.tsx

Line 52 in c6a763f

onClose={() => navigateToConciergeChatAndDeleteReport(report?.reportID ?? reportID, undefined, true)}

What changes do you think we should make in order to solve the problem?

Navigating to concierge and deleting the report works well if the report is an optimistic one but in this case it not. Therefore, we should first check if the report is optimistic via ${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID} isOptimisticReport and if it is optimistic we will navigateToConciergeChatAndDeleteReport otherwise we will need to only clear errors via clearReportFieldKeyErrors and stay on the report
Update

App/src/pages/home/report/ReportActionItemCreated.tsx

Line 52 in fe62640

onClose={() => navigateToConciergeChatAndDeleteReport(report?.reportID ?? reportID, undefined, true)}

    const [reportMetadata] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`);



            onClose={() => handleCreateChatError(report, reportMetadata?.isOptimisticReport)}

function handleCreateChatError(report: Report, isOptimisticReport: boolean) {
    if (report?.errorFields?.createChat && isOptimisticReport) {
        clearReportFieldKeyErrors(reportID, 'createChat');
        return;
    }
    navigateToConciergeChatAndDeleteReport(report?.reportID, undefined, true);
}

Similar problems can happen in all other instances we use navigateToConciergeChatAndDeleteReport so we can create handleCreateChatError and put the above logic in it and use it everywhere.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can write a test for handleCreateChatError that it only clears error and doesn't delete the report if the report is not optimistic.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021894711298971649891

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[melvin-bot]

@abdulrahuman5196 Eep! 4 days overdue now. Issues have feelings too...