[Due for payment 2025-04-23] [$250] Android - Chat - User navigated to incorrect section when opening notification and tapping back button

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.1-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Email or phone of affected tester (no customers): ibellicotest+262@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12
App Component: Notifications

Action Performed:

1. Open the Expensify app.
2. Tap on "Reports" on the bottom of the screen.
3. Switch to user B account.
4. Send a message to User A.
5. Tap on the notification received.
6. When redirected to chat, tap on the arrow on the top left corner.
7. Check if you are navigated to "Reports" again or to "Inbox"
8. Tap on "Settings"
9. Repeat steps 3 to 7.

Expected Result:

When tapping on the back button on chat, the user should land on the section that was opened before interacting with the message notification.

Actual Result:

When tapping on back button on chat, user lands on inbox, despite being in a different section when interacting with the message notification.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6747571_1739951807611.Notification.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021892735148257300596
• Upwork Job ID: 1892735148257300596
• Last Price Increase: 2025-02-28
• Automatic offers:
• truph01 | Contributor | 106372661

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sakluger]

This one is kinda confusing, but I think I understand. It looks like:

1. User B (the account with an email address and a blue avatar) navigated to the Settings page of their New Expensify app.
2. User B leaves the Expensify app
3. User A (the account of Ignacio, with the green avatar) sent a message to User B
4. User B gets a push notification and clicks on the notification, but instead of going directly to the chat, they are dropped back on the Settings page where the were previously

I agree that this is not expected behavior - we should navigate users to the correct chat according to the notification, no matter where they were in the app previously.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021892735148257300596

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• When tapping on back button on chat, user lands on inbox, despite being in a different section when interacting with the message notification.

What is the root cause of that problem?

• When user clicks on the notification, we open the report screen:
  

  App/src/libs/Notification/PushNotification/subscribePushNotification/index.ts

  Line 117 in 14c5b21

  Navigation.navigateToReportWithPolicyCheck({reportID: String(reportID), policyIDToCheck: policyID});

• Then when we going back, we just call Navigation.goBack():

App/src/pages/home/ReportScreen.tsx

Line 336 in 14c5b21

Navigation.goBack(undefined, {shouldPopToTop: true});

so the incorrect section will be opened. In detail, the LHN is always opened after clicking on back button.

What changes do you think we should make in order to solve the problem?

• We should add the backTo parameter to the route when user navigates to report by clicking notification. Then, when going back, we check whether the backTo param exists. If so, use Navigation.goBack(backTo) instead.

1. Add backTo param to:

App/src/libs/Notification/PushNotification/subscribePushNotification/index.ts

Line 117 in 14c5b21

Navigation.navigateToReportWithPolicyCheck({reportID: String(reportID), policyIDToCheck: policyID});

                Navigation.navigateToReportWithPolicyCheck({reportID: String(reportID), policyIDToCheck: policyID, backTo: Navigation.getActiveRoute()});

2. In here:

App/src/libs/Navigation/Navigation.ts

Line 484 in 14c5b21

linkTo(ref.current, ROUTES.REPORT_WITH_ID.getRoute(targetReport?.reportID ?? '-1', reportActionID, referrer));

use the above backTo:

        linkTo(ref.current, ROUTES.REPORT_WITH_ID.getRoute(targetReport?.reportID ?? '-1', reportActionID, referrer, backTo ? getActiveRoute() : undefined));

and here:

App/src/libs/Navigation/Navigation.ts

Line 499 in 14c5b21

    if (backTo) {
        params.backTo = backTo;
    }

3. Update ROUTES.REPORT_WITH_ID.getRoute to receive the additional backTo parameter. This is simple since we did it in a lot of routes in app.

4. Update:

App/src/pages/home/ReportScreen.tsx

Line 336 in 14c5b21

Navigation.goBack(undefined, {shouldPopToTop: true});

        if (route.params?.backTo) {
            Navigation.goBack(route.params?.backTo, {shouldPopToTop: true});
            return;
        }
        Navigation.goBack(undefined, {shouldPopToTop: true});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• NA

What alternative solutions did you explore? (Optional)