[Due for payment 2025-03-10] [$250] Cards - No space between last selection and next button

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Login as applausetester+ccardfeed@applause.expensifail.com
3. Go to workspace settings - company card test do not delete
4. Tap expensify card- issue card
5. Select a user
6. Tap back and note user is not shown as selected
7. Tap company card - assign card
8. Select a last user
9. Note here page design is different with next button and no space between last user and next button.
10. Tap next
11. Select last card in list
12. Note no space between last card and next button
13. Tap back button
14. User remains selected

Expected Result:

Issue card and assign card selecting member design must be consistent. There must be space between last selection and next button

Actual Result:

Issue card and assign card selecting member design is inconsistent. No space between last selection and next button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6745932_1739812109269.Screenrecorder-2025-02-17-22-27-00-709.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021892535268930867316
• Upwork Job ID: 1892535268930867316
• Last Price Increase: 2025-02-20
• Automatic offers:
• linhvovan29546 | Contributor | 106258006

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-17 18:00:04 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Issue card and assign card selecting member design is inconsistent. No space between last selection and next button

What is the root cause of that problem?

We are not adding margin bottom to this selection list or adding margin top to confirm button

App/src/pages/workspace/companyCards/assignCard/AssigneeStep.tsx

Lines 182 to 200 in 37de406

	<SelectionList
	textInputLabel={textInputLabel}
	textInputValue={searchTerm}
	onChangeText={setSearchTerm}
	sections={sections}
	headerMessage={headerMessage}
	ListItem={UserListItem}
	onSelectRow={selectMember}
	initiallyFocusedOptionKey={selectedMember}
	shouldUpdateFocusedIndex
	/>
	<FormAlertWithSubmitButton
	buttonText={translate(isEditing ? 'common.confirm' : 'common.next')}
	onSubmit={submit}
	isAlertVisible={shouldShowError}
	containerStyles={styles.ph5}
	message={translate('common.error.pleaseSelectOne')}
	buttonStyles={styles.mb5}
	/>

App/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx

Lines 166 to 173 in 37de406

	<FormAlertWithSubmitButton
	buttonText={translate(isEditing ? 'common.confirm' : 'common.next')}
	onSubmit={submit}
	isAlertVisible={shouldShowError}
	containerStyles={styles.ph5}
	message={translate('common.error.pleaseSelectOne')}
	buttonStyles={styles.mb5}
	/>

What changes do you think we should make in order to solve the problem?

We can add styles.mt5 to confirm button like we did with SelectBankStep

App/src/pages/workspace/companyCards/assignCard/AssigneeStep.tsx

Lines 193 to 200 in 37de406

	<FormAlertWithSubmitButton
	buttonText={translate(isEditing ? 'common.confirm' : 'common.next')}
	onSubmit={submit}
	isAlertVisible={shouldShowError}
	containerStyles={styles.ph5}
	message={translate('common.error.pleaseSelectOne')}
	buttonStyles={styles.mb5}
	/>

App/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx

Lines 166 to 173 in 37de406

	<FormAlertWithSubmitButton
	buttonText={translate(isEditing ? 'common.confirm' : 'common.next')}
	onSubmit={submit}
	isAlertVisible={shouldShowError}
	containerStyles={styles.ph5}
	message={translate('common.error.pleaseSelectOne')}
	buttonStyles={styles.mb5}
	/>

Or we can add styles.mb5 for selectionList above

Note: some minor styles can be discuss in PR phase

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cards - No space between last selection and next button

What is the root cause of that problem?

There is no spacing above the confirm button, causing the last item in the list and the confirm button to appear too close together.

App/src/pages/workspace/companyCards/assignCard/AssigneeStep.tsx

Lines 182 to 200 in 37de406

	<SelectionList
	textInputLabel={textInputLabel}
	textInputValue={searchTerm}
	onChangeText={setSearchTerm}
	sections={sections}
	headerMessage={headerMessage}
	ListItem={UserListItem}
	onSelectRow={selectMember}
	initiallyFocusedOptionKey={selectedMember}
	shouldUpdateFocusedIndex
	/>
	<FormAlertWithSubmitButton
	buttonText={translate(isEditing ? 'common.confirm' : 'common.next')}
	onSubmit={submit}
	isAlertVisible={shouldShowError}
	containerStyles={styles.ph5}
	message={translate('common.error.pleaseSelectOne')}
	buttonStyles={styles.mb5}
	/>

App/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx

Lines 132 to 174 in 37de406

	<>
	<SelectionList
	sections={[{data: searchedListOptions}]}
	headerMessage={searchedListOptions.length ? undefined : translate('common.noResultsFound')}
	shouldShowTextInput={cardListOptions.length > CONST.COMPANY_CARDS.CARD_LIST_THRESHOLD}
	textInputLabel={translate('common.search')}
	textInputValue={searchText}
	onChangeText={setSearchText}
	ListItem={RadioListItem}
	onSelectRow={({value}) => handleSelectCard(value)}
	initiallyFocusedOptionKey={cardSelected}
	listHeaderContent={
	<View>
	<View style={[styles.ph5, styles.mb5, styles.mt3, {height: CONST.BANK_ACCOUNT.STEPS_HEADER_HEIGHT}]}>
	<InteractiveStepSubHeader
	startStepIndex={1}
	stepNames={CONST.COMPANY_CARD.STEP_NAMES}
	/>
	</View>
	<Text style={[styles.textHeadlineLineHeightXXL, styles.ph5, styles.mt3]}>{translate('workspace.companyCards.chooseCard')}</Text>
	<Text style={[styles.textSupporting, styles.ph5, styles.mv3]}>
	{translate('workspace.companyCards.chooseCardFor', {
	assignee: assigneeDisplayName,
	feed: getBankName(feed),
	})}
	</Text>
	</View>
	}
	shouldShowTextInputAfterHeader
	shouldShowHeaderMessageAfterHeader
	includeSafeAreaPaddingBottom={false}
	shouldShowListEmptyContent={false}
	shouldUpdateFocusedIndex
	/>
	<FormAlertWithSubmitButton
	buttonText={translate(isEditing ? 'common.confirm' : 'common.next')}
	onSubmit={submit}
	isAlertVisible={shouldShowError}
	containerStyles={styles.ph5}
	message={translate('common.error.pleaseSelectOne')}
	buttonStyles={styles.mb5}
	/>
	</>

What changes do you think we should make to solve the problem?

We should add a margin top to the containerStyles of the confirm button. Note: The margin top should only be added when there is no error message, as the error message already has its own spacing.

App/src/pages/workspace/companyCards/assignCard/AssigneeStep.tsx

Lines 193 to 200 in 37de406

	<FormAlertWithSubmitButton
	buttonText={translate(isEditing ? 'common.confirm' : 'common.next')}
	onSubmit={submit}
	isAlertVisible={shouldShowError}
	containerStyles={styles.ph5}
	message={translate('common.error.pleaseSelectOne')}
	buttonStyles={styles.mb5}
	/>

                     containerStyles={[styles.ph5, !shouldShowError && styles.mt5]}

App/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx

Lines 166 to 173 in 37de406

	<FormAlertWithSubmitButton
	buttonText={translate(isEditing ? 'common.confirm' : 'common.next')}
	onSubmit={submit}
	isAlertVisible={shouldShowError}
	containerStyles={styles.ph5}
	message={translate('common.error.pleaseSelectOne')}
	buttonStyles={styles.mb5}
	/>

                    containerStyles={[styles.ph5, !shouldShowError && styles.mt5]}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A, UI bug

What alternative solutions did you explore? (Optional)

We can add !shouldShowError && styles.mt5 to buttonStyles instead containerStyles

[dylanexpensify]

@lanitochka17 is this only with a tester account?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021892535268930867316

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[lanitochka17]

@dylanexpensify This issue occurs with two more testers

screen-20250217-193743.mp4

[ahmedGaber93]

@nkdengineer @linhvovan29546 are you able to add a company cards? If yes, please let me know the steps?