[Due for payment 2025-03-05] [$250] Tooltips - Workspace chat tooltip is shown for workspace chat and workspace task report

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.99-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new account.
3. Go to Account settings > Workspaces.
4. Click New workspace button to create a new workspace.
5. On workspace settings page, click on the workspace chat.
6. On workspace chat, click + > Assign task.
7. Create a task.
8. Go to the task report.
9. Send a reply.
10. Open another chat in LHN, other than workspace chat and task report.
11. Open FAB to dismiss FAB tooltip.

Expected Result:

There will be only one tooltip which is for the workspace chat.

Actual Result:

There are two tooltips - one for workspace chat, another one for workspace task report.

Another issue - Task report has three lines in the header (Step 8).

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6745822_1739805303574.20250217_230908.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021892081957972685258
• Upwork Job ID: 1892081957972685258
• Last Price Increase: 2025-02-19
• Automatic offers:
• nkdengineer | Contributor | 106209014

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-17 15:57:46 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are two tooltips - one for workspace chat, another one for workspace task report.

What is the root cause of that problem?

The task report of policy expense chat still have the same chatType then this also matches this condition

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 64 in 9370c43

const shouldShowWokspaceChatTooltip = isPolicyExpenseChat(report) && activePolicyID === report?.policyID && session?.accountID === report?.ownerAccountID;

What changes do you think we should make in order to solve the problem?

We need to add !isThread condition here to prevent this tooltip can be shown for the child report of the policy expense chat

const shouldShowWokspaceChatTooltip = isPolicyExpenseChat(report) && !isThread(report) && activePolicyID === report?.policyID && session?.accountID === report?.ownerAccountID;

or we can use !optionItem?.isTaskReport

const shouldShowWokspaceChatTooltip = isPolicyExpenseChat(report) && !optionItem?.isTaskReport && activePolicyID === report?.policyID && session?.accountID === report?.ownerAccountID;

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 64 in 9370c43

const shouldShowWokspaceChatTooltip = isPolicyExpenseChat(report) && activePolicyID === report?.policyID && session?.accountID === report?.ownerAccountID;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021892081957972685258

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[hoangzinh]

@nkdengineer's proposal looks good to me

Link to proposal #56952 (comment)

🎀👀🎀 C+ reviewed