[$250] Room - Whisper to invite member, disappears when mentioning another user.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.95-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5570997&group_by=cases:section_id&group_order=asc&group_id=229067
Email or phone of affected tester (no customers): ibellicotest+231@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Other

Action Performed:

1. Open the Expensify app.
2. Open any room conversation or create one if necessary.
3. Mention any user that is not part of the room.
4. After the whisper message to send an invitation is displayed, mention a different user that is not part of the room.
5. Check if the first whisper message is still displayed on chat.
6. If the whisper disappeared, navigate to LHN and reopen the room conversation.

Expected Result:

First whisper message to invite a new member to the room, should remain on chat, despite a second user being mentioned.

Actual Result:

Whisper message to invite a new member to room, disappears when mentioning a second user and reappears after navigating to inbox and returning to room.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6735927_1738909439462.Whisper.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021887957031211666394
• Upwork Job ID: 1887957031211666394
• Last Price Increase: 2025-02-14

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021887957031211666394

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

[NJ-2020]

Same root cause as here, BE issue, the BE delete the previous whisper
#47255 (comment)

Screen.Recording.2025-02-08.at.10.09.38.mov

We close this issue without a fix

[DylanDylann]

It seems a BE bug, when adding the second message, the BE returns Onyx data with message.deleted field in the first whisper message --> the first whisper message is hidden

But when openReport API is called again, this API returns message.deleted field in the first whisper message as empty --> the first whisper message is displayed again

[ikevin127]

Proposal

Please re-state the problem that we are trying to solve in this issue

Concierge whisper to invite new member disappears when mentioning another new user.

What is the root cause of that problem?

Context: The last similar issue was closed as not an engineering priority.

The root cause comes from the AddComment BE response which for some reason deletes the ACTIONABLEMENTIONWHISPER report action of the previously mentioned user whenever we mention the next new user.

This is resolved if the user will close and reopen the report which calls the OpenReport and returns the correct BE data which will display the ACTIONABLEMENTIONWHISPER report action because the deleted field will become empty instead of containing a date which causes the isDeletedAction function to return true.

Breakdown of what happens in isDeletedAction:

• when we add a second mention, isLegacyDeletedComment becomes true because of message.at(0)?.html === ''
• at the end of the function, even if isLegacyDeletedComment would be false (which is not in our case), there's still the !!message.at(0)?.deleted additional check which in our issue's case would also return true

Recap: In our issue's case both isLegacyDeletedComment and !!message.at(0)?.deleted return true

What changes do you think we should make in order to solve the problem?

Since the last issue was closed as not an engineering priority meaning BE didn't have capacity to fix it, and the issue seems to keep being reported, we can attempt to fix this from the FE side.

Before doing so we have to consider and understand the context of how the current isDeletedAction function came to be from PR #36747.

What we can do in our case is to change the function's return statement to basically skip the check only for ACTIONABLEMENTIONWHISPER actions (Concierge - Invite Whisper) using isActionableMentionWhisper:

-    return isLegacyDeletedComment || !!message.at(0)?.deleted;
+    return (isLegacyDeletedComment || !!message.at(0)?.deleted) && !isActionableMentionWhisper(reportAction as OnyxEntry<ReportAction>);

this will fix our issue according to the Expected result while still hiding the (Concierge - Invite Whisper) when the user presses either Invite them or Do nothing. All other deleted report action types will work just like before.

Another reason for which this will work as expected is because ACTIONABLEMENTIONWHISPER (CONST.REPORT.ACTIONS.TYPE.ACTIONABLE_MENTION_WHISPER) is only used for this 1 action type, the proof can be found in the getActionableMentionWhisperMessage function.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

If we implement the main solution, in ReportActionsUtilsTest we can test that the updated isDeletedAction function will return false if the report action type is ACTIONABLEMENTIONWHISPER, and true as expected for all other report action types.

What alternative solutions did you explore? (Optional)

Fix the issue on the BE side in Web-Expensify, some more context here in a previous PR which implemented the deleted timestamp logic.

Result video (before / after)

MacOS: Chrome

Before	After
before.mov	after.mov

[melvin-bot]

@isabelastisser, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!