[Due for payment 2025-03-11] [$250] Company card - Card when unassigned offline is still clickable in Wallet page

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.92-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5529642
Email or phone of affected tester (no customers): applausetester+ccardfeed@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• User has assigned themselves a card from Company cards page.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Company card.
3. Go offline.
4. Click on the card.
5. Click Unassign card.
6. Click Unassign.
7. Click on the card which has strikethrough style now.
8. Note that the unassigned card is now clickable.
9. Go to account settings > Wallet.
10. Click on the unassigned card.

Expected Result:

The unassigned card should not be clickable as it is unassigned and has strikethrough style.

Actual Result:

The unassigned card is clickable and it opens context menu.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021886307400190065658
• Upwork Job ID: 1886307400190065658
• Last Price Increase: 2025-02-17
• Automatic offers:
• ZhenjaHorbach | Reviewer | 106204048
• cretadn22 | Contributor | 106204049

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[twilight2294]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-30 14:30:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Card when unassigned offline is still clickable in Wallet page

What is the root cause of that problem?

We do not disable the interactive state of the card if the user is offline and the action is pending delete:

We always set it to true:

App/src/pages/settings/Wallet/PaymentMethodList.tsx

Line 227 in 54dcbde

interactive: true,

What changes do you think we should make in order to solve the problem?

We need to check if the user is not offline and the pending action is not delete:

interactive: (card.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) && !isOffline, 

If necessary do the same for expensify cards

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A this is a UI bug

What alternative solutions did you explore? (Optional)

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The unassigned card is still clickable on the Wallet page when offline

What is the root cause of that problem?

App/src/pages/settings/Wallet/PaymentMethodList.tsx

Line 227 in 49128c8

interactive: true,

We always set interactive to true and do not assign a value to the disabled field

What changes do you think we should make in order to solve the problem?

In these places:

App/src/pages/settings/Wallet/PaymentMethodList.tsx

Line 227 in 49128c8

interactive: true,

App/src/pages/settings/Wallet/PaymentMethodList.tsx

Line 283 in 49128c8

interactive: true,

Let's add a variable to determine when the card row should be disabled or if there are errors, following the same approach used in other places.

                    const isDisabled = card.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || !!card.errors
                    assignedCardsGrouped.push({
                        ..........
                        interactive: !isDisabled,
                        disabled: isDisabled,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is unnecessary

What alternative solutions did you explore? (Optional)

No

[VictoriaExpensify]

Agree this is a bug that should be fixed

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021886307400190065658

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[ZhenjaHorbach]

@twilight2294 @cretadn22
Thanks for your proposals !
I will check today or tomorrow