[Due for payment 2025-02-18] Per diem - Per diem expense is marked as non-billable when it is created as billable

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.91-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace has per diem rates.
• Expenses are marked as billable by default.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Create expense > Per diem.
4. Complete the steps and reach the confirmation page.
5. Note that Billable toggle is enabled by default.
6. Submit the expense.
7. Go to transaction thread.

Expected Result:

Billable toggle will be enabled in the transaction thread because the expense is created as billable.

Actual Result:

Billable toggle is disabled in the transaction thread when the expense is created as billable.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @maddylewis

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[shubham1206agra]

@Gonals We don't allow billable option in PerDiem, correct?

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Billable toggle is disabled in the transaction thread when the expense is created as billable.

What is the root cause of that problem?

• In here:

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 308 in acd7a79

transactionParams: {

we didn't pass the billable data. So, BE has not received the information about that field, so the per-diem expense is always marked as non-billable.

What changes do you think we should make in order to solve the problem?

• In here:

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 308 in acd7a79

transactionParams: {

we can pass billable: transaction?.billable.

• Then in here:

App/src/libs/actions/IOU.ts

Line 4432 in acd7a79

const {currency, comment = '', category, tag, created, customUnit} = transactionParams;

expose the billable data.

• Then pass the above billable data to:

App/src/libs/actions/IOU.ts

Line 4470 in acd7a79

const parameters: CreatePerDiemRequestParams = {

• In here:

App/src/libs/actions/IOU.ts

Line 2788 in acd7a79

const {comment = '', currency, created, category, tag, customUnit} = transactionParams;

expose the billable data.

• Then in here:

App/src/libs/actions/IOU.ts

Line 2853 in acd7a79

transactionParams: {

pass the above billable data.

• BE needs to make sure the param billable is acceptable as well.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

• We can hide the billable option in confirmation page:

App/src/components/MoneyRequestConfirmationListFooter.tsx

Line 262 in acd7a79

const shouldShowBillable = policy?.disabledFields?.defaultBillable === false;

    const shouldShowBillable = policy?.disabledFields?.defaultBillable === false && !isPerDiemRequest;

and

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 213 in acd7a79

const shouldShowBillable = isPolicyExpenseChat && (!!transactionBillable || !(policy?.disabledFields?.defaultBillable ?? true) || !!updatedTransaction?.billable);

    const shouldShowBillable = !isPerDiemRequest && isPolicyExpenseChat && (!!transactionBillable || !(policy?.disabledFields?.defaultBillable ?? true) || !!updatedTransaction?.billable);

[Gonals]

I'll take care of this as part of the Per Diem project