[HOLD for payment 2025-02-07] [$250] Subscription: Currency selected incorrectly after page reload

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.88-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Go to Subscription page
2. Click Add payment card
3. Change currency to AUD
4. Reload page
5. Observe currency it has been reset to USD
6. Click on currency field

Expected Result:

USD option is selected

Actual Result:

AUD option is selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

bug.mov

Recording.915.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021881985646640917256
• Upwork Job ID: 1881985646640917256
• Last Price Increase: 2025-01-22
• Automatic offers:
• DylanDylann | Reviewer | 105877710
• ikevin127 | Contributor | 105877713

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Currency selected incorrectly after page reload

What is the root cause of that problem?

Because we previously set the currency to AUD, when reloading, the debitCardForm here still has the currency as AUD even though Onyx has updated it to USD.

App/src/pages/settings/PaymentCard/ChangeCurrency/index.tsx

Line 18 in 059368f

const [debitCardForm] = useOnyx(ONYXKEYS.FORMS.ADD_PAYMENT_CARD_FORM);

What changes do you think we should make in order to solve the problem?

we should add option initWithStoredValues ​​as false similar to what we did elsewhere

    const [debitCardForm] = useOnyx(ONYXKEYS.FORMS.ADD_PAYMENT_CARD_FORM, {initWithStoredValues: false});

We can do the same with pages that have similar problems.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021881985646640917256

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[DylanDylann]

@daledah's proposal looks good to me. To ensure that the previous state does not impact the rendering of the current page, we need to set initWithStoredValues to false

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.