[Due for payment 2025-03-05] [$250] Track expense - Wrong position of the "New Message" line when track expense offline

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.88-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Mac 15.2
App Component: Chat Report View

Action Performed:

1. Open the app or navigate to https://staging.new.expensify.com
2. Track expense in the Self DM
3. Click Categorize it in the actionable whisper and finish the flow to move the expense to the workspace chat
4. Navigate to Self DM
5. Disable the connection
6. Create a new track expense

Expected Result:

The "New Message" line is displayed above the created track expense and actionable whisper menu while offline or no "New Message" marker appears

Actual Result:

The "New Message" line is displayed under the created track expense while offline

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021884333549452358300
• Upwork Job ID: 1884333549452358300
• Last Price Increase: 2025-02-04
• Automatic offers:
• rayane-d | Reviewer | 106062960

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[M00rish]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-21 22:01:06 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track expense - Wrong position of the "New Message" line when track expense offline

What is the root cause of that problem?

logic is not couting for offline case

What changes do you think we should make in order to solve the problem?

add check for offline :

App/src/pages/home/report/PureReportActionItem.tsx

Line 1109 in 9b31270

{shouldDisplayNewMarker && (!shouldUseThreadDividerLine || !isFirstVisibleReportAction) && <UnreadActionIndicator reportActionID={action.reportActionID} />}

{!isOffline && shouldDisplayNewMarker && (!shouldUseThreadDividerLine || !isFirstVisibleReportAction) && <UnreadActionIndicator reportActionID={action.reportActionID} />}

or don't show UnreadActionIndicator for ACTIONABLETRACKEXPENSEWHISPER

{action.actionName !== CONST.REPORT.ACTIONS.TYPE.ACTIONABLE_TRACK_EXPENSE_WHISPER && shouldDisplayNewMarker  .....

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI issue

What alternative solutions did you explore? (Optional)

another solution is filter out whisper actions in reportActionsList :

    const sortedwithoutWhisperReportActions = useMemo(() => {
    return sortedVisibleReportActions.filter(
        (reportAction) => reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.ACTIONABLE_TRACK_EXPENSE_WHISPER
    );
}, [sortedVisibleReportActions]); 

    const prevsortedwithoutWhisperReportActions = usePrevious(sortedwithoutWhisperReportActions);

and replace them here :

App/src/pages/home/report/ReportActionsList.tsx

Line 276 in f71f36e

const unreadMarkerReportActionID = useMemo(() => {

Details

[bernhardoj]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-22 03:01:37 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The new message marker position is shown on the track expense actionable whisper.

What is the root cause of that problem?

The actionable whisper is detected as a message that is received while the user is offline.

App/src/pages/home/report/ReportActionsList.tsx

Lines 281 to 285 in 0190b0a

	// If the current message is the earliest message received while offline, we want to display the unread marker above this message.
	const isEarliestReceivedOfflineMessage = index === earliestReceivedOfflineMessageIndex;
	if (isEarliestReceivedOfflineMessage && !isNextMessageUnread) {
	return true;
	}

This is the logic to decide whether the message is received while offline or not.

App/src/pages/home/report/ReportActionsList.tsx

Lines 250 to 254 in 0190b0a

	const wasMessageReceivedWhileOffline = useCallback(
	(message: OnyxTypes.ReportAction) =>
	!wasActionTakenByCurrentUser(message) && wasActionCreatedWhileOffline(message, isOffline, lastOfflineAt.current, lastOnlineAt.current, preferredLocale),
	[isOffline, lastOfflineAt, lastOnlineAt, preferredLocale],
	);

App/src/libs/ReportActionsUtils.ts

Lines 1862 to 1887 in 0190b0a

	function wasActionCreatedWhileOffline(action: ReportAction, isOffline: boolean, lastOfflineAt: Date | undefined, lastOnlineAt: Date | undefined, locale: Locale): boolean {
	// The user was never online.
	if (!lastOnlineAt) {
	return true;
	}
	// The user never was never offline.
	if (!lastOfflineAt) {
	return false;
	}
	const actionCreatedAt = DateUtils.getLocalDateFromDatetime(locale, action.created);
	// The action was created before the user went offline.
	if (actionCreatedAt <= lastOfflineAt) {
	return false;
	}
	// The action was created while the user was offline.
	if (isOffline || actionCreatedAt < lastOnlineAt) {
	return true;
	}
	// The action was created after the user went back online.
	return false;
	}

The logic was added in #49480 to show a new message marker when the user receives a message from another user/actor while offline. In our case, the actor of the actionable whisper is concierge. The problem is, in wasActionCreatedWhileOffline, if the app is currently offline, then the message is marked as received while offline.

App/src/libs/ReportActionsUtils.ts

Lines 1873 to 1883 in 0190b0a

	const actionCreatedAt = DateUtils.getLocalDateFromDatetime(locale, action.created);
	// The action was created before the user went offline.
	if (actionCreatedAt <= lastOfflineAt) {
	return false;
	}
	// The action was created while the user was offline.
	if (isOffline || actionCreatedAt < lastOnlineAt) {
	return true;
	}

Based on the logic above, this can only happens if an optimistic action was added while the user is offline.

What changes do you think we should make in order to solve the problem?

I don't think we want to mark an optimistic action as unread even when it's not from the current user, so I suggest to remove the isOffline check from wasActionCreatedWhileOffline.

App/src/libs/ReportActionsUtils.ts

Lines 1880 to 1883 in 0190b0a

	// The action was created while the user was offline.
	if (isOffline || actionCreatedAt < lastOnlineAt) {
	return true;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add a new test to UnreadIndicatorsTest to make sure there is no unread marker line when tracking an expense.

[melvin-bot]

@slafortune Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021884333549452358300

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)