[Due for payment 2025-02-13] [$250] Get started tooltip shown on multiple #admins room.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation (hyperlinked to channel name): convert

Action Performed:

1. Login with new account
2. Choose to manage a team for purpose of onboarding flow
3. Create another workspace
4. Pin all admin rooms
5. Refresh the page

Expected Result:

Only one "get started" tooltip on the admin room

Actual Result:

Get started tooltip shown on multiple #admins room.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

More details in the OP post in the slack

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021881474402423530233
• Upwork Job ID: 1881474402423530233
• Last Price Increase: 2025-01-20
• Automatic offers:
• DylanDylann | Reviewer | 105793171
• nkdengineer | Contributor | 105793175

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-20 17:27:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Get started tooltip shown on multiple #admins room.

What is the root cause of that problem?

If the onboarding is a guide assigned, we always show the get started tooltip for all admin reports.

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 65 in bc29231

const shouldShowGetStartedTooltip = isOnboardingGuideAssigned ? isAdminRoom(report) : isConciergeChatReport(report);

What changes do you think we should make in order to solve the problem?

We should only show the get started tooltip for the admin report is the guide assigned admin room. We can get this admin room from account.adminsRoomReportID.

const shouldShowGetStartedTooltip = isOnboardingGuideAssigned ? isAdminRoom(report) && report?.reportID === account?.adminsRoomReportID : isConciergeChatReport(report);

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 65 in bc29231

const shouldShowGetStartedTooltip = isOnboardingGuideAssigned ? isAdminRoom(report) : isConciergeChatReport(report);

We need to call getAssignedSupportData API to get the support data. We can do this in SidebarLinks to prevent it's called many times.

useEffect(() => {
    if (!activePolicyID) {
        return;
    }
    getAssignedSupportData(activePolicyID);
}, [activePolicyID]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is a UI issue so I don't think we need the test.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[DylanDylann]

I can reproduce this bug:

Steps:

1. Login with new account
2. Choose to manage a team for purpose of onboarding flow
3. Create another workspace
4. Pin all admin rooms
5. Refresh the page

Screen.Recording.2025-01-21.at.00.20.48.mov

[DylanDylann]

I should take over this bug as C+ as mentioned here

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021881474402423530233