Able to receive messages after login out

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with two accounts side by side
2. On account A - Open a new tab and go to https://staging.new.expensify.com/
3. In the new tab - open the menu and log out
4. Close the tab and return to the original (main) tab
5. Observe you're logged out
6. On account B
7. Start to send messages to account A
8. See new messages arriving on account A

Expected Result:

User should not receive any notification or message after logging out.

Actual Result:

The notification number is updated in tab. More information from @kidroca:

It seems we're not logging out cleanly when it happens from a secondary tab
When that happens the Pusher connection is still active on the main tab and even though we're on the Login Page we receive new messages - you can see them in the tab title e.g. "(5) New Expensify" also in application storage

Workaround:

Unknown (?) I think there's no need for workaround.

Platform:

Where is this issue confirmed?

• Web

Version Number: 1.1.2.-5

Reproducible in staging?: yes
Reproducible in production?: yes
Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

logout.notification.mp4

Expensify/Expensify Issue URL:

Issue reported by: @kidroca
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1632747432107300

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[chiragsalian]

Will investigate today.

[marcaaron]

I think this is being fixed here. Can we please retest this on staging and close this issue? I don’t think it’s possible anymore.

[chiragsalian]

Tested and i am unable to reproduce the issue on staging. I think it has been fixed. Closing issue but @isagoico if you are able to reproduce feel free to reopen.