[Due for payment 2025-05-22] [Due for payment 2025-02-13] [$250] Workflows - Street doesn't get automatically filled out for a specific address

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.86-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): nathanmulugetatesting+2818@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace
3. Enable workflows
4. Go through plaid connection method
5. Go through the flow until step 2 (What's your address?)
6. Type "1" on street address
7. Click on "1132 Murphy Ridge Rd" from the options

Expected Result:

Street address gets filled out automatically

Actual Result:

Street address stays empty and validation error is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6714924_1736961211864.bandicam_2025-01-15_20-08-19-028.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021882178300262274254
• Upwork Job ID: 1882178300262274254
• Last Price Increase: 2025-01-22
• Automatic offers:
• Krishna2323 | Contributor | 105905250

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mohit6789]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Street doesn't get automatically filled out for a specific address

What is the root cause of that problem?

Currently, in input field we are displaying ${street_number} ${route} from here. If ${street_number} ${route} not present then we display street name from here.

But in some edge-case google place API does not return the street_number, route and street-address, because of that input value set to empty and we see validation error.

What changes do you think we should make in order to solve the problem?

To fix this issue we can write below code here.

if (!values.street && autocompleteData?.structured_formatting?.main_text) {
    values.street = autocompleteData?.structured_formatting?.main_text;
}

Here if street value is empty then we can show the street name from the autocompleteData.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI bug so NA

What alternative solutions did you explore? (Optional)

[Krishna2323]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-16 04:34:46 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workflows - Street doesn't get automatically filled out for a specific address

What is the root cause of that problem?

• We are getting the streetNumber & streetName using GooglePlacesUtils.getAddressComponents(addressComponents but for some locations the addressComponents doesn't include the streetNumber & streetName.
  

  App/src/components/AddressSearch/index.tsx

  Lines 127 to 155 in 5133090

  	// Gather the values from the Google details
  	const {
  	street_number: streetNumber,
  	route: streetName,
  	subpremise,
  	locality,
  	sublocality,
  	postal_town: postalTown,
  	postal_code: zipCode,
  	administrative_area_level_1: state,
  	administrative_area_level_2: stateFallback,
  	country: countryPrimary,
  	} = GooglePlacesUtils.getAddressComponents(addressComponents, {
  	// eslint-disable-next-line @typescript-eslint/naming-convention
  	street_number: 'long_name',
  	route: 'long_name',
  	subpremise: 'long_name',
  	locality: 'long_name',
  	sublocality: 'long_name',
  	// eslint-disable-next-line @typescript-eslint/naming-convention
  	postal_town: 'long_name',
  	// eslint-disable-next-line @typescript-eslint/naming-convention
  	postal_code: 'long_name',
  	// eslint-disable-next-line @typescript-eslint/naming-convention
  	administrative_area_level_1: 'short_name',
  	// eslint-disable-next-line @typescript-eslint/naming-convention
  	administrative_area_level_2: 'long_name',
  	country: 'short_name',
  	});

  
  

  App/src/components/AddressSearch/index.tsx

  Line 178 in 5133090

  street: `${streetNumber} ${streetName}`.trim(),

What changes do you think we should make in order to solve the problem?

• First we need to update getPlaceAutocompleteTerms to also return streetNumber, we can do that by simply adding streetNumber to fieldsToExtract.
  

  App/src/libs/GooglePlacesUtils.ts

  Line 36 in 5133090

  type GetPlaceAutocompleteTermsResultKey = 'country' | 'state' | 'city' | 'street';

  
  

  App/src/libs/GooglePlacesUtils.ts

  Lines 39 to 51 in 5133090

  	/**
  	* Finds an address term by type, and returns the value associated to key. Note that each term in the address must
  	* conform to the following ORDER: <street, city, state, country>
  	*/
  	function getPlaceAutocompleteTerms(addressTerms: AddressTerm[]): GetPlaceAutocompleteTermsResult {
  	const fieldsToExtract: GetPlaceAutocompleteTermsResultKey[] = ['country', 'state', 'city', 'street'];
  	const result: GetPlaceAutocompleteTermsResult = {};
  	fieldsToExtract.forEach((fieldToExtract, index) => {
  	const fieldTermIndex = addressTerms.length - (index + 1);
  	result[fieldToExtract] = fieldTermIndex >= 0 ? addressTerms.at(fieldTermIndex)?.value : '';
  	});
  	return result;
  	}

• Then we would need to extract the street and streetNumber from getPlaceAutocompleteTerms, we will name them streetFallback & streetNumberFallback.
  

  App/src/components/AddressSearch/index.tsx

  Lines 166 to 170 in 5133090

  	const {
  	country: countryFallbackLongName = '',
  	state: stateAutoCompleteFallback = '',
  	city: cityAutocompleteFallback = '',
  	} = GooglePlacesUtils.getPlaceAutocompleteTerms(autocompleteData?.terms ?? []);

• Finally, we will use || operator to add streetFallback & streetNumberFallback as fallback value.
  

  App/src/components/AddressSearch/index.tsx

  Lines 177 to 178 in 5133090

  	const values = {
  	street: `${streetNumber} ${streetName}`.trim(),

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?


NA

What alternative solutions did you explore? (Optional)

Result

Monosnap.screencast.2025-01-16.10-01-58.mp4

[github-actions]

⚠️ @Krishna2323 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[ishakakkad]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Street doesn't get automatically filled out for a specific address.

What is the root cause of that problem?

We are using street_number and route from details?.address_components, but in some of the case street_number and route does not exist because of the input value set to empty and validation error throws.

What changes do you think we should make in order to solve the problem?

To fix issue we can we can make below changes.

1. As per @Krishna2323's suggestion, we can modify the code in the following location:

Return street and streetNumber from here

App/src/libs/GooglePlacesUtils.ts

Lines 36 to 51 in 5133090

	type GetPlaceAutocompleteTermsResultKey = 'country' | 'state' | 'city' | 'street';
	type GetPlaceAutocompleteTermsResult = Partial<Record<GetPlaceAutocompleteTermsResultKey, string>>;
	/**
	* Finds an address term by type, and returns the value associated to key. Note that each term in the address must
	* conform to the following ORDER: <street, city, state, country>
	*/
	function getPlaceAutocompleteTerms(addressTerms: AddressTerm[]): GetPlaceAutocompleteTermsResult {
	const fieldsToExtract: GetPlaceAutocompleteTermsResultKey[] = ['country', 'state', 'city', 'street'];
	const result: GetPlaceAutocompleteTermsResult = {};
	fieldsToExtract.forEach((fieldToExtract, index) => {
	const fieldTermIndex = addressTerms.length - (index + 1);
	result[fieldToExtract] = fieldTermIndex >= 0 ? addressTerms.at(fieldTermIndex)?.value : '';
	});
	return result;
	}

and use this as a fallback values here

App/src/components/AddressSearch/index.tsx

Line 178 in 5133090

street: `${streetNumber} ${streetName}`.trim(),

However, it is important to note that in some edge cases, the street and streetNumber from getPlaceAutocompleteTerms may not return the necessary data.

2. To handle edge cases where street and streetNumber from getPlaceAutocompleteTerms do not return data, we should implement an additional check at the following location https://github.com/Expensify/App/blob/main/src/components/AddressSearch/index.tsx#L224 as suggested by @mohit6789 . The reason for this is that structured_formatting?.main_text is selected dropdown display text and can serve as a reliable fallback.

if (!values.street && autocompleteData?.structured_formatting?.main_text) {
    values.street = autocompleteData?.structured_formatting?.main_text;
}

Note: While this proposal may seem similar to the suggestions from @mohit6789 and @Krishna2323, it is still worth mentioning as a necessary addition.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

[melvin-bot]

@CortneyOfstad Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021882178300262274254