[HOLD for payment 2025-02-04] [$75] Expense - Cancelled spelling is different & full stop in system message is shown

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.0.85-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): N
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Money Requests

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open a workspace chat
3. Create a expense
4. Open the expense
5. Select pay elsewhere from drop-down
6. Pay the expense
7. Tap header - cancel the payment
8. Note the title above amount field and system message below the expense

Expected Result:

• The system message should spell canceled with one l, and should not have a full stop.

Copy: "canceled the %amount% payment"

Actual Result:

The system message uses the (arguably superior) spelling of cancelled and includes a full stop.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6714051_1736867814161.Screenrecorder-2025-01-14-20-35-45-983_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021879342639421320206
• Upwork Job ID: 1879342639421320206
• Last Price Increase: 2025-01-15

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

🚨 Edited by proposal-police: This proposal was edited at 2025-01-14 16:35:36 UTC.

🚨 Edited by proposal-police: This proposal was edited at 2025-01-14 16:35:36 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Cancelled spelling is different & full stop in system message is shown

What is the root cause of that problem?

We define this message in iou.adminCanceledRequest

App/src/languages/en.ts

Line 973 in 0da9621

adminCanceledRequest: ({manager, amount}: AdminCanceledRequestParams) => `${manager ? `${manager}: ` : ''}cancelled the ${amount} payment.`,

What changes do you think we should make in order to solve the problem?

We should remove a dot at the end of this translation and update cancelled to canceled

 adminCanceledRequest: ({manager, amount}: AdminCanceledRequestParams) => `${manager ? `${manager}: ` : ''}canceled the ${amount} payment`,

Note: We should do the same with translations that have a dot at the end. Example iou.payerSettledWithMissingBankAccount, iou.waitingOnBankAccount, iou.payerSettledWithMissingBankAccount...

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format.

[huult]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-16 18:04:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cancelled spelling is different & full stop in system message is shown

What is the root cause of that problem?

This is a translation issue. The issue uses 'cancelled' and includes a period at the end.

App/src/languages/en.ts

Line 973 in ae97b24

adminCanceledRequest: ({manager, amount}: AdminCanceledRequestParams) => `${manager ? `${manager}: ` : ''}cancelled the ${amount} payment.`,

What changes do you think we should make in order to solve the problem?

To fix this issue, we must update cancelled to canceled to ensure consistency with other instances and remove the period at the end. It should look something like this

App/src/languages/en.ts

Line 973 in ae97b24

adminCanceledRequest: ({manager, amount}: AdminCanceledRequestParams) => `${manager ? `${manager}: ` : ''}cancelled the ${amount} payment.`,

adminCanceledRequest: ({manager, amount}: AdminCanceledRequestParams) => `${manager ? `${manager}: ` : ''}canceled the ${amount} payment`,

And we should remove the period at the end for ‘es’ as well.

App/src/languages/es.ts

Line 969 in 3db57e8

adminCanceledRequest: ({manager, amount}: AdminCanceledRequestParams) => `${manager ? `${manager}: ` : ''}canceló el pago de ${amount}.`,

To make it consistent, we should remove the period at the end for violationDismissal.rter, iou.adminCanceledRequest, etc. We should remove the period at the end in both en and es

Note: My proposal differs from the previous proposal because the previous proposal only fixes one case, but we have two cases: the difference in canceled and the dot at the end

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is a UI bug and does not require testing.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[trjExpensify]

@jamesdeanexpensify Jaaaaaames. Can you confirm here before I move it on? Is it:

• Canceled should only use one l because America is so great, yada yada yada.
• The system message should not have a full stop. (Btw, a full stop is what we call a period.. just to avoid you having to use google translate for that mate 😏 😛).

Here's a still from the OP for ease:

[jamesdeanexpensify]

Right on both (fortunately or unfortunately lol)

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[trjExpensify]

lolol. Updated the OP. Dropping the price for this small copy update.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021879342639421320206