[HOLD for payment 2025-02-07] [$250] Users can't submit a report that contains no reimbursable expenses

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation (hyperlinked to channel name): #retain

Action Performed:

1. Go to NewDot, create a workspace.
2. Go to Settings > Workspaces > [Click the workspace] > Enable Workflows
3. Go to Workflows > Enable delayed submission and set it to Manually > Enable approvals.
4. Go to Members > invite a member to the workspace
5. [Member] Click the green plus icon > Create expense > choose the workspace > confirm
6. Observe the Submit button on the report preview, in the report header, and on the search page.
7. [Member] Click Settings > Domains (to transition over to OldDot)
8. [Member] Go to the Expenses page > click into the expense > uncheck the reimbursable checkmark
9. [Member] open the NewDot tab > refresh
10. Observe the Submit button is no longer visible on the report preview, report header or search page.

Expected Result:

Users should be able to see the Submit button on an expense report that contains only non-reimbursable expenses, providing they aren't all pending transactions.

Actual Result:

There's no Submit button on an expense report that contains only non-reimbursable expenses.

Note: I think this line here is culprit. Perhaps it's also in a few other places where you see the submit button.

Workaround:

They can submit via OldDot.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2025-01-10_18-28-51.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021877786460553153940
• Upwork Job ID: 1877786460553153940
• Last Price Increase: 2025-01-10
• Automatic offers:
• shubham1206agra | Contributor | 105671141
• ishpaul777 | Contributor | 105671147

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021877786460553153940

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[allroundexperts]

@trjExpensify Your clue is accurate.

[allroundexperts]

We need to remove the condition here in the money report header as well. There's also a condition in the submission action that we need to remove.

[allgandalf]

@trjExpensify Your clue is accurate.

@trjExpensify is gonna take our job away !!!!!