[Due for payment 2025-02-10] [$250] Update the default copy in the `Description` section of the workspace profile AND update the copy in the last step of the workspace invite flow

[jamesdeanexpensify]

Background

Coming from this convo, we want to do two things:

1. Update the default Description in the workspace profile to: One place for all your receipts and expenses. Here's where I'm talking about:

2. Update the pre-filled copy in the last step of the workspace invite flow to: Please use Expensify to submit your receipts for reimbursement, thanks!. Here's where I'm talking about:

Important note

Currently, whatever is the default Description in the workspace profile (#1 above) becomes the pre-filled copy in the last step of the workspace invite flow (#2 above). We don't want that to happen moving forward.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021878937872409435665
• Upwork Job ID: 1878937872409435665
• Last Price Increase: 2025-01-20
• Automatic offers:
• Krishna2323 | Contributor | 105787768

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2025-01-10 02:36:01 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the default copy in the Description section of the workspace profile AND decouple it from the last step of the workspace invite flow

What is the root cause of that problem?

• Improvement

What changes do you think we should make in order to solve the problem?

• Create a new translation in en and es file for One place for all your receipts and expenses..
• Use the new translation in WorkspaceProfilePage and WorkspaceProfileDescriptionPage in place of welcomeNote.
• Update the welcome not translation to simply return Welcome to Expensify, the easy way to manage receipts and expenses! and from WorkspaceInviteMessagePage, remove the translation param (workspace name)
  

  App/src/languages/en.ts

  Lines 2589 to 2590 in 63f0c9f

  	welcomeNote: ({workspaceName}: WelcomeNoteParams) =>
  	`You've been invited to ${workspaceName || 'a workspace'}! Get the most out of Expensify by downloading the app at use.expensify.com/download.`,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?


What alternative solutions did you explore? (Optional)

[github-actions]

El comentario contiene todas las líneas obligatorias del formulario de propuesta. Por lo tanto, responder con NO_ACTION.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want to update the copy of the workspace profile description.

What is the root cause of that problem?

Copy update.

What changes do you think we should make in order to solve the problem?

Update the default Description in the workspace profile to: One place for all your receipts and expenses.

First, we need to create a new translation key on the en.ts and es.ts files.

description: One place for all your receipts and expenses.

Then, use the new translation here (without the parser replace).

App/src/pages/workspace/WorkspaceProfilePage.tsx

Lines 114 to 122 in b77ff58

	const policyDescription =
	// policy?.description can be an empty string
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	policy?.description ||
	Parser.replace(
	translate('workspace.common.welcomeNote', {
	workspaceName: policy?.name ?? '',
	}),
	);

translate('workspace.common.defaultDescription')

Lastly, update it here too.

App/src/pages/workspace/WorkspaceProfileDescriptionPage.tsx

Lines 30 to 41 in b77ff58

	const [description, setDescription] = useState(() =>
	Parser.htmlToMarkdown(
	// policy?.description can be an empty string
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	policy?.description ||
	Parser.replace(
	translate('workspace.common.welcomeNote', {
	workspaceName: policy?.name ?? '',
	}),
	),
	),
	);

Update the pre-filled copy in the last step of the workspace invite flow to: Welcome to Expensify, the easy way to manage receipts and expenses!

We need to update the welcomeNote translation here to Welcome to Expensify, the easy way to manage receipts and expenses!.

App/src/languages/en.ts

Lines 2589 to 2590 in 7b8bb55

	welcomeNote: ({workspaceName}: WelcomeNoteParams) =>
	`You've been invited to ${workspaceName || 'a workspace'}! Get the most out of Expensify by downloading the app at use.expensify.com/download.`,

Since we don't need the param anymore, we need to delete it too.

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 78 to 80 in 7b8bb55

	translate('workspace.common.welcomeNote', {
	workspaceName: policy?.name ?? '',
	}))

translate('workspace.common.welcomeNote')

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[github-actions]

anlaursen Your proposal will be dismissed because you did not follow the proposal template.

[Krishna2323]

PROPOSAL UPDATED

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the default copy in the Description section of the workspace profile AND decouple it from the last step of the workspace invite flow

What is the root cause of that problem?

Update the default description for the workspace profile.

What changes do you think we should make in order to solve the problem?

1. Add a new key (e.g., workspaceDescription) to en.ts and es.ts in the src/languages directory

// workspace.common.workspaceDescription

  en: One place for all your receipts and expenses.
  es: Un lugar para todos sus recibos y gastos.

2. Update new key for WorkspaceProfilePage and WorkspaceProfileDescriptionPage

App/src/pages/workspace/WorkspaceProfilePage.tsx

Line 113 in a565510

const policyDescription =

Update to:

    const policyDescription =
      // policy?.description can be an empty string
      // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
      policy?.description || Parser.replace(translate('workspace.common.workspaceDescription'));

App/src/pages/workspace/WorkspaceProfileDescriptionPage.tsx

Line 35 in 99f1873

Parser.replace(

Update to:

    Parser.htmlToMarkdown(
        // policy?.description can be an empty string
        // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
        policy?.description || Parser.replace(translate('workspace.common.workspaceDescription')),
    ),

POC

Screen.Recording.2025-01-10.at.12.12.43.mp4

2. Currently, both WorkspaceProfilePage and WorkspaceProfileDescriptionPage use policy?.description, and because WorkspaceInviteMessagePage also uses the same policy?.description, any changes in WorkspaceProfilePage or WorkspaceProfileDescriptionPage will also affect WorkspaceInviteMessagePage. To resolve this, we will use a different default description for WorkspaceInviteMessagePage by introducing a new key, for example, policy?.inviteMessageDescription, specifically for this page. With this, we may need backend changes, or we can explore alternative solutions during the pull request phase.

A video describing what I mentioned

Screen.Recording.2025-01-10.at.12.12.59.mp4

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Line 77 in 1a7a15a

(Parser.htmlToMarkdown(policy?.description ?? '') ||

Update to:

  (Parser.htmlToMarkdown(policy?.inviteMessageDescription ?? '') ||

policy?.inviteMessageDescription is the new key we defined for the WorkspaceInviteMessagePage.

and update welcomeNote to welcomeNote: 'Welcome to Expensify, the easy way to manage receipts and expenses!',

App/src/languages/en.ts

Line 2588 in ae97b24

welcomeNote: ({workspaceName}: WelcomeNoteParams) =>

App/src/languages/es.ts

Line 2611 in ae97b24

welcomeNote: ({workspaceName}: WelcomeNoteParams) =>

and

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Line 78 in 1a7a15a

translate('workspace.common.welcomeNote', {

update to

(... || translate('workspace.common.welcomeNote'))

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

1. should display the updated default description
2. should not affect other pages using inviteMessageDescription

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jamesdeanexpensify]

Hi all - HEADS UP - I've updated the comment at the very top of this issue to hopefully be much more descriptive and added in some new copy suggestions. Please take a look!