[Due for payment 2025-05-14] [Hold for #53175][$125] Update task copy to include links for the newDotAdmin case

[danielrvidal]

Currently we show these tasks to an admin when they are invited as a new user to a workspace and login is as an admin. I believe we apply the introSelected NVP: newDotAdmin

And here is if you click into the second, which shows a bug:

We would like to update the copy to include links to the workspace in the Task header and in the task body. The updated copy for the two tasks we would like to update are as follows:

Task 1:

Meet your setup specialist
No change to copy in task chat as it already links to room in the message.

The link in the task should link them to their workspace settings URL.

Task 2:

Review your workspace settings
Here’s how to review and update your workspace settings:

1. Click the settings tab.
2. Click Workspaces > [Your workspace]

Go to your workspace. We’ll track any changes in the #admins room.

The link in the both URLs should link them to their workspace settings URL.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021877116348555119982
• Upwork Job ID: 1877116348555119982
• Last Price Increase: 2025-01-08
• Automatic offers:
• truph01 | Contributor | 105715224

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021877116348555119982

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

@Shahidullah-Muffakir Your proposal will be dismissed because you did not follow the proposal template.

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We need to update the task copy to include links for the newDotAdmin case.

What is the root cause of that problem?

The workspaceSettingsLink is not being added in the following two places:

• First instance
• Second instance

Additionally, when an admin is invited to the workspace, the onboardingPolicyID will be "-1"

What changes do you think we should make in order to solve the problem?

1. We need to adjust how we handle the onboardingPolicyID and use the adminWorkspace's policyID when the admin is invited to the workspace.
   when an admin is invited to the workspace, the onboardingPolicyID will be "-1", so we need to use the policyID of the workspace where the admin is invited instead.
   as:

let allPolicies: OnyxCollection<Policy>;
Onyx.connect({
    key: ONYXKEYS.COLLECTION.POLICY,
    waitForCollectionCallback: true,
    callback: (value) => (allPolicies = value),
});

const adminWorkspace = Object.values(allPolicies ?? {})?.find((policy: Policy) => policy.role === CONST.POLICY.ROLE.ADMIN && isPaidGroupPolicy(policy));
const isAdmin = engagementChoice === CONST.ONBOARDING_CHOICES.ADMIN;
const policyId = isAdmin ? adminWorkspace?.id : onboardingPolicyID ?? '-1';

and then pass it here instead of onboardingPolicyID:

App/src/libs/actions/Report.ts

Line 3643 in 5fb81d6

workspaceSettingsLink: `${environmentURL}/${ROUTES.WORKSPACE_INITIAL.getRoute(onboardingPolicyID ?? '-1')}`,

as:

workspaceSettingsLink: `${environmentURL}/${ROUTES.WORKSPACE_INITIAL.getRoute(policyId)}`,

2. We should accept the workspaceSettingsLink as a parameter in the description and use it in both of these places:

3. In the meetSetupSpecialist section:

   {
       type: 'meetSetupSpecialist',
       autoCompleted: false,
       title: 'Meet Your Setup Specialist',
       description: ({ workspaceSettingsLink }) =>
           `*Meet your* [setup specialist](${workspaceSettingsLink}) who can answer any questions as you get started with Expensify. Yes, a real human!\n` +
           'Chat with them in your #admins room or schedule a call today.',
   },

4. In the reviewWorkspaceSettings section:

   {
       type: 'reviewWorkspaceSettings',
       autoCompleted: false,
       title: 'Review Your Workspace Settings',
       description: ({ workspaceSettingsLink }) =>
           `Here's how to review and update your workspace settings:\n` +
           '1. Click the settings tab.\n' +
           `2. Click *Workspaces*  > [Your workspace](${workspaceSettingsLink})\n` +
           `Go to [your workspace](${workspaceSettingsLink}). We’ll track any changes in the #admins room.`,
   }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Screen.20Recording.202025-01-09.20at.208.mp4

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

• Task 1: We didn't add the link to the title:

App/src/CONST.ts

Line 5205 in 557432d

title: 'Meet your setup specialist',

• Task 2: We didn't add the link to the title:

App/src/CONST.ts

Line 5214 in 557432d

title: 'Review your workspace settings',

and the link to the description:

App/src/CONST.ts

Lines 5215 to 5221 in 557432d

	description:
	"Here's how to review and update your workspace settings:" +
	'\n' +
	'1. Click the settings tab.' +
	'2. Click *Workspaces* > [Your workspace].' +
	'\n' +
	"Make any changes there and we'll track them in the #admins room.",

What changes do you think we should make in order to solve the problem?

Step 1: Get the correct onboardingPolicyID data.

• In:
  

  App/src/libs/actions/Report.ts

  Line 895 in 5fb81d6

  const onboardingData = prepareOnboardingOptimisticData(choice, onboardingMessage);

  
  we didn't pass the onboardingPolicyID param, which leads to the workspaceSettingsLink in:

App/src/libs/actions/Report.ts

Line 3643 in 5fb81d6

workspaceSettingsLink: `${environmentURL}/${ROUTES.WORKSPACE_INITIAL.getRoute(onboardingPolicyID ?? '-1')}`,

is -1.

• To fix it, we need to pass the policyID data when calling prepareOnboardingOptimisticData function:

App/src/libs/actions/Report.ts

Line 895 in 5fb81d6

const onboardingData = prepareOnboardingOptimisticData(choice, onboardingMessage);

            const onboardingData = prepareOnboardingOptimisticData(choice, onboardingMessage, undefined, policy?.id);

with policy = getActivePolicies(policies, currentUserEmail).find((policy) => policy.type !== 'personal' && getPolicyRole(policy, currentUserEmail) === 'admin').

Step 2. Add the link to the task's title.

• We can update the task's title:

App/src/CONST.ts

Line 5205 in 557432d

title: 'Meet your setup specialist',

                    title: ({workspaceSettingsLink}) => `Meet your [setup specialist](${workspaceSettingsLink})`,

and

App/src/CONST.ts

Line 5214 in 557432d

title: 'Review your workspace settings',

                    title: ({workspaceSettingsLink}) => `Review your [workspace settings](${workspaceSettingsLink})`,

• Then pass the workspaceSettingsLink to the title function:

App/src/libs/actions/Report.ts

Line 3649 in 5fb81d6

integrationName,

                          integrationName,
                          workspaceSettingsLink: `${environmentURL}/${ROUTES.WORKSPACE_INITIAL.getRoute(policy.id ?? '-1')}`,
                      })

• Note: The policy comes from step 1. And, this step should be held until feature: Upgrade task titles with markdown rendering is done.

Step 3: Add the link to the task's description

and this

description: ({workspaceSettingsLink}) =>
                        "Here's how to review and update your workspace settings:\n" +
                        '1. Click the settings tab.\n' +
                        '2. Click *Workspaces* > [Your workspace].\n' +
                        `[Go to your workspace](${workspaceSettingsLink}). We'll track them in the #admins room.`,

What alternative solutions did you explore? (Optional)

[Christinadobrzyn]

Hi @alitoshmatov can you check out these proposals? Thank you!