[$250] Don't require report fields to be enabled to set the Custom report names rule

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: No
Email or phone of affected tester (no customers): tom+reportfieldlock1@trj.chat
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: None, discovered while testing something else.

Action Performed:

1. Go to new.expensify.com
2. Sign-up for a new account
3. Go to Settings > Workspaces > [Click the workspace] > More features > Enable Rules
4. Go to Rules
5. Observe the toggle on "custom report names" is locked.

Expected Result:

The "custom report names" feature shouldn't require the report fields feature to be enabled on the workspace.

Actual Result:

You have to enable report fields first before you can enable the custom report names rule.

Workaround:

Yes, enable report fields in more features.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2025-01-08_10-55-13.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021876948044546438787
• Upwork Job ID: 1876948044546438787
• Last Price Increase: 2025-01-15

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021876948044546438787

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Shahidullah-Muffakir]

Edited by proposal-police: This proposal was edited at 2025-01-08 11:16:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Don't require report fields to be enabled to set the Custom report names rule

What is the root cause of that problem?

here we are using: areReportFieldsEnabled,

App/src/pages/workspace/rules/ExpenseReportRulesSection.tsx

Line 27 in 26f00c0

const customReportNamesUnavailable = !policy?.areReportFieldsEnabled;

What changes do you think we should make in order to solve the problem?

we should use areRulesEnabled instead of areReportFieldsEnabled
const customReportNamesUnavailable = !policy?.areRulesEnabled;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Since the ExpenseReportRulesSection component is only displayed on the Rules page, which itself is only accessible when policy?.areRulesEnabled is true, we can safely remove the disabled and showLockIcon properties and modify the Subtitle as:

App/src/pages/workspace/rules/ExpenseReportRulesSection.tsx

Lines 54 to 61 in 26f00c0

	title: translate('workspace.rules.expenseReportRules.customReportNamesTitle'),
	subtitle: customReportNamesUnavailable
	? renderFallbackSubtitle({featureName: translate('workspace.common.reportFields').toLowerCase(), variant: 'enable'})
	: translate('workspace.rules.expenseReportRules.customReportNamesSubtitle'),
	switchAccessibilityLabel: translate('workspace.rules.expenseReportRules.customReportNamesTitle'),
	isActive: policy?.shouldShowCustomReportTitleOption,
	disabled: customReportNamesUnavailable,
	showLockIcon: customReportNamesUnavailable,

- const customReportNamesUnavailable = !policy?.areReportFieldsEnabled;


+ subtitle: translate('workspace.rules.expenseReportRules.customReportNamesSubtitle'),
- disabled: customReportNamesUnavailable,
- showLockIcon: customReportNamesUnavailable,

[github-actions]

defining the problem, identifying the root cause, and suggesting changes. Some extra non-mandatory content is present, but it does not affect the adherence to the mandatory lines. Therefore, the proposal is valid even if there is an extra non-mandatory section present.

• There are three mandatory lines for a proposal (even though they sometimes contain no user content), and an optional fourth section which is correctly marked.
• The proposal follows the correct template with bold headings for each section, even incorporating additional comments or links, which are allowable.

NO_ACTION

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2025-01-08 11:17:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

You have to enable report fields first before you can enable the custom report names rule.

What is the root cause of that problem?

We are setting condition here

App/src/pages/workspace/rules/ExpenseReportRulesSection.tsx

Line 27 in 26f00c0

const customReportNamesUnavailable = !policy?.areReportFieldsEnabled;

What changes do you think we should make in order to solve the problem?

We can remove this condition or set customReportNamesUnavailable = false

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.