[HOLD for payment 2025-01-15] Advanced approval workflow doesn't work after disabling and re enabling it

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.78-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #52537
Email or phone of affected tester (no customers): nathanmulugetatesting+2612@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 pro/chrome
App Component: Money Requests

Action Performed:

Pre conditions:

• Create a workspace as an owner
• Enable workflows and setup an advanced workflow where submitter submits to approver 1 then approver 1 approves to approver 2

1. Submit an expense as the submitter
2. Sign in as the approver 1 and approve the expense
3. Sign in as the approver 2 and approve the expense
4. As the owner disable approval and re enable it after a few seconds
5. Submit another expense as the submitter

Expected Result:

The submitted expense appears for approver 1 to approve

Actual Result:

The submitted expense directly goes to owner to approve and approve 1 is not the one doing the approving first as per the workflow setup

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6702037_1735124150981.bandicam_2024-12-25_13-44-46-350.1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

@Beamanator Is this a BE bug? After we disable and enable approval again the approvalMode is BASIC not ADVANCE

[Beamanator]

Innnnnnnteresting... That sounds like something @tgolen has worked on in the backend recently if this has to do with changing the approval mode via NewDot

[melvin-bot]

@slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[slafortune]

@tgolen thoughts on this?

[tgolen]

I don't think this is a backend issue.

When the workflows are disabled, the FE calls the SetWorkspaceApprovalMode command with the value value: {"approver":"tgolen@expensify.com","approvalMode":"OPTIONAL","isAutoApprovalEnabled":false}. You can see the approval mode being set to OPTIONAL.

When the workflows are enabled again, the FE calls the SetWorkspaceApprovalMode with the value value: {"approver":"tgolen@expensify.com","approvalMode":"BASIC","isAutoApprovalEnabled":false}. You can see the approval mode is being set to BASIC.

The frontend should be setting it to ADVANCED.

[nkdengineer]

@tgolen We're always passing BASIC here when enabling the approval. How can we detect the approval modal should be basic or not? I can work on this after we can clarify a way to detect that.

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 166 in 5da6a32

Policy.setWorkspaceApprovalMode(route.params.policyID, policy?.owner ?? '', isEnabled ? CONST.POLICY.APPROVAL_MODE.BASIC : CONST.POLICY.APPROVAL_MODE.OPTIONAL);

[tgolen]

I noticed that after I enabled workflows, the UI still showed both workflows that I previously added. So, I assume that the workflow data still exists in Onyx. If that's the case, then you can pass BASIC if there was a single workflow and pass ADVANCED if there were multiple workflows.

[nkdengineer]

@tgolen Just tested and it works well. I noticed that we could have another case that is also advance approval mode is only has one workflow but multiple approvers. Here is the solution and I'd like to work on this.

const isAdvanceApproval = approvalWorkflows.length > 1 || (approvalWorkflows?.at(0)?.approvers ?? []).length > 1;
const approvalMode = isAdvanceApproval ? CONST.POLICY.APPROVAL_MODE.ADVANCED : CONST.POLICY.APPROVAL_MODE.BASIC;
Policy.setWorkspaceApprovalMode(route.params.policyID, policy?.owner ?? '', isEnabled ? approvalMode : CONST.POLICY.APPROVAL_MODE.OPTIONAL);