[HOLD for payment 2025-01-02] [$50] Inconsistent display of measurement units

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.76-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Try uploading an avatar with an image larger than 6 MB.
2. Try adding a attachment with a file larger than 24 MB.
3. Observe the error displayed.

Expected Result:

Consistent display of measurement units

Actual Result:

We are displaying inconsistently "6MB" and "24 MB".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence


View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021869142033023958876
• Upwork Job ID: 1869142033023958876
• Last Price Increase: 2024-12-18
• Automatic offers:
• shubham1206agra | Contributor | 105392311

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dukenv0307]

@Christinadobrzyn I can help take this issue as C+ since I have the context on it

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent display of measurement units

What is the root cause of that problem?

In translation files

App/src/languages/en.ts

Line 512 in d86024e

sizeExceeded: 'Attachment size is larger than 24 MB limit',

App/src/languages/en.ts

Line 522 in d86024e

sizeExceededWithValue: ({maxUploadSizeInMB}: SizeExceededParams) => `Files exceeds ${maxUploadSizeInMB}MB. Please try again.`,

App/src/languages/en.ts

Line 1087 in d86024e

sizeExceeded: ({maxUploadSizeInMB}: SizeExceededParams) => `The selected image exceeds the maximum upload size of ${maxUploadSizeInMB}MB.`,

App/src/languages/en.ts

Line 1253 in d86024e

logSizeTooLarge: ({size}: LogSizeParams) => `Log size exceeds the limit of ${size} MB. Please use "Save log" to download the log file instead.`,

The translation of size is inconsistent.

What changes do you think we should make in order to solve the problem?

Make the above translations consistent. @jamesdeanexpensify can chime in here for the translations

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA since it is a UI change

What alternative solutions did you explore? (Optional)

NA

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent display of measurement units

What is the root cause of that problem?

We are inconsistently create the translation copies

App/src/languages/en.ts

Line 1087 in d86024e

sizeExceeded: ({maxUploadSizeInMB}: SizeExceededParams) => `The selected image exceeds the maximum upload size of ${maxUploadSizeInMB}MB.`,

App/src/languages/en.ts

Line 512 in d86024e

sizeExceeded: 'Attachment size is larger than 24 MB limit',

What changes do you think we should make in order to solve the problem?

Add space before MB in the following copies, and its translation in .es file

App/src/languages/en.ts

Line 522 in d86024e

sizeExceededWithValue: ({maxUploadSizeInMB}: SizeExceededParams) => `Files exceeds ${maxUploadSizeInMB}MB. Please try again.`,

App/src/languages/en.ts

Line 1087 in d86024e

sizeExceeded: ({maxUploadSizeInMB}: SizeExceededParams) => `The selected image exceeds the maximum upload size of ${maxUploadSizeInMB}MB.`,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[daledah]

Edited by proposal-police: This proposal was edited at 2024-12-17 02:40:04 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are displaying inconsistently "6MB" and "24 MB".

What is the root cause of that problem?

We are not consistent when displaying measurement units

App/src/languages/en.ts

Line 512 in d86024e

sizeExceeded: 'Attachment size is larger than 24 MB limit',

App/src/languages/en.ts

Line 522 in d86024e

sizeExceededWithValue: ({maxUploadSizeInMB}: SizeExceededParams) => `Files exceeds ${maxUploadSizeInMB}MB. Please try again.`,

What changes do you think we should make in order to solve the problem?

We can remove space before MB

App/src/languages/en.ts

Line 512 in d86024e

sizeExceeded: 'Attachment size is larger than 24 MB limit',

App/src/languages/en.ts

Line 1253 in d86024e

logSizeTooLarge: ({size}: LogSizeParams) => `Log size exceeds the limit of ${size} MB. Please use "Save log" to download the log file instead.`,

Also need to change in es.ts file

OPTIONAL: We can remove space in here and here

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021869142033023958876

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)