[HOLD for payment 2025-01-21] [HOLD for payment 2025-01-18] [$250] Workflows -"Delay submissions" is auto-enabled after upgrading workspace and then auto-disabled

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh03120001@applause.expensifail.com
**Issue reported by:**Applause - Internal Team
**Component ** Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace
3. Go to workspace settings > More features
4. Enable Workflows
5. Go to Workflows
6. Enable Add approvals
7. Click Add approval workflow
8. Click Upgrade
9. Note that "Delay submissions" toggle is enabled
10. Close the upgrade successful RHP

Expected Result:

"Delay submissions" toggle should not change when upgrading workspace to Control and closing upgrade successful RHP

Actual Result:

"Delay submissions" toggle is enabled after upgrading workspace to Control, and disabled after closing upgrade successful RHP

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6692325_1734016783320.bandicam_2024-12-12_23-14-16-190.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021869129717738672469
• Upwork Job ID: 1869129717738672469
• Last Price Increase: 2024-12-24
• Automatic offers:
• FitseTLT | Contributor | 105541961

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

madisonruth1992 Your proposal will be dismissed because you did not follow the proposal template.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-12-12 16:04:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workflows -"Delay submissions" is auto-enabled after upgrading workspace and then auto-disabled

What is the root cause of that problem?

We always turn on the toggle when the autoReportingFrequency is not instant

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 156 in 50c1db8

isActive: (policy?.autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT && !hasDelayedSubmissionError) ?? false,

and in this case we are setting it to immediate optimistically on upgrade to corporate

App/src/libs/actions/Policy/Policy.ts

Line 3386 in 50c1db8

autoReportingFrequency: CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE,

it will be disabled again when the policy is fetched from BE on dismiss modal

What changes do you think we should make in order to solve the problem?

We leave it to instant same as the BE returns, so remove

App/src/libs/actions/Policy/Policy.ts

Lines 3384 to 3387 in 50c1db8

	...(PolicyUtils.isInstantSubmitEnabled(policy) && {
	autoReporting: true,
	autoReportingFrequency: CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE,
	}),

also we don't need

App/src/libs/actions/Policy/Policy.ts

Lines 3416 to 3417 in 50c1db8

	autoReporting: policy?.autoReporting ?? null,
	autoReportingFrequency: policy?.autoReportingFrequency ?? null,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add a test for upgradeToCorporate to assert that it doesn't alter autoReportingFrequency to immediate when it was instant.

What alternative solutions did you explore? (Optional)

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Delay submissions" is auto-enabled after upgrading workspace and then auto-disabled

What is the root cause of that problem?

When we upgradeToCorporate, we check if the policy is instant submit enabled. If yes, we automatically update autoReportingFrequency to CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE and enable autoReporting. As a result, the button delay submission is enabled.

App/src/libs/actions/Policy/Policy.ts

Lines 3401 to 3407 in 815b4ed

	...(PolicyUtils.isInstantSubmitEnabled(policy) && {
	autoReporting: true,
	autoReportingFrequency: CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE,
	}),
	harvesting: {
	enabled: false,
	},

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Line 155 in d03d4b4

isActive: (policy?.autoReportingFrequency !== CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT && !hasDelayedSubmissionError) ?? false,

After that, when we click Got it, thanks, it triggers the OpenPolicyWorkflowsPage call. The API responds with autoReportingFrequency set to instant. For this reason, the button delay submission is disabled.

Screen.Recording.2024-12-13.at.12.20.38.mov

The reason is that we set autoReportingFrequency to CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE in upgradeToCorporate, but the backend did not update the database. As a result, OpenPolicyWorkflowsPage still responds with the old value, causing this issue to occur.

What changes do you think we should make in order to solve the problem?

To resolve this issue, we should use SET_WORKSPACE_AUTO_REPORTING_FREQUENCY to set autoReportingFrequency to CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE, something like this:

We removed that logic from the optimisticData.

App/src/libs/actions/Policy/Policy.ts

Lines 3401 to 3407 in 815b4ed

	...(PolicyUtils.isInstantSubmitEnabled(policy) && {
	autoReporting: true,
	autoReportingFrequency: CONST.POLICY.AUTO_REPORTING_FREQUENCIES.IMMEDIATE,
	}),
	harvesting: {
	enabled: false,
	},

And when we upgradeToCorporate, we check if the policy is instant submit enabled, then call setWorkspaceAutoReportingFrequency with the frequency set to CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL

App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx

Lines 92 to 98 in 8bbeaef

	const upgradeToCorporate = () => {
	if (!canPerformUpgrade) {
	return;
	}
	Policy.upgradeToCorporate(policy.id, feature?.name);
	};

to

    const upgradeToCorporate = () => {
        if (!canPerformUpgrade) {
            return;
        }

        if (PolicyUtils.isInstantSubmitEnabled(policy)) {
            Policy.setWorkspaceAutoReportingFrequency(policy.id, CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL);
        }

        Policy.upgradeToCorporate(policy.id, feature?.name);
    };

POC

Screen.Recording.2024-12-13.at.12.43.48.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

1. Scenario 1: If canPerformUpgrade is false, ensure no actions are performed.
2. Scenario 2: If isInstantSubmitEnabled(policy) returns true, verify setWorkspaceAutoReportingFrequency is called with CONST.POLICY.AUTO_REPORTING_FREQUENCIES.MANUAL.
3. Scenario 3: If isInstantSubmitEnabled(policy) returns false, ensure setWorkspaceAutoReportingFrequency is not called.
4. Scenario 4: If feature is undefined, check that Policy.upgradeToCorporate is called with undefined for the feature name.
5. Scenario 5: If canPerformUpgrade is true and isInstantSubmitEnabled(policy) returns true, ensure both setWorkspaceAutoReportingFrequency and upgradeToCorporate are called.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@CortneyOfstad Whoops! This issue is 2 days overdue. Let's get this updated quick!

[CortneyOfstad]

Was able to recreate, so going to get eyes on this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021869129717738672469