[Due for payment 2025-02-10] [$250] Scan Receipt - No message when deleting a receipt from a scanned report

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.75-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5334039
Email or phone of affected tester (no customers): applauseexpensifyteam+groupd@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

1. Log in as the employee
2. Navigate to a expense request conversation that has a receipt
3. Click on the receipt thumbnail
4. Verify there's a 3 dot menu on the top right
5. Click on Delete Receipt
6. Verify there's a modal to confirm the receipt deletion
7. Confirm the action
8. Verify the receipt is deleted from the request

Expected Result:

Verify a system message is posted in the conversation indicating the receipt was removed

Actual Result:

When deleting the receipt no message is displayed in the conversation.
It appears only after refreshing the page

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6691887_1733990857111.Nomessagewhendeletereciept.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021867401523775541525
• Upwork Job ID: 1867401523775541525
• Last Price Increase: 2024-12-13

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[linhvovan29546]

Edited by proposal-police: This proposal was edited at 2024-12-12 15:48:23 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When deleting the receipt no message is displayed in the conversation.
It appears only after refreshing the page

What is the root cause of that problem?

In the Report screen, there is logic to filter report actions here. When the DetachReceipt API is called, it returns onyxData with an empty message format("html": ""). This causes the shouldReportActionBeVisible
function to mark the action as isDeletedAction (isDeleted=true), resulting in the message not being displayed.

App/src/libs/ReportActionsUtils.ts

Lines 691 to 694 in 94ab9cd

	const isDeleted = isDeletedAction(reportAction);
	const isPending = !!reportAction.pendingAction;
	return !isDeleted || isPending || isDeletedParentAction(reportAction) || isReversedTransaction(reportAction);

App/src/libs/ReportActionsUtils.ts

Lines 133 to 144 in 94ab9cd

	function isDeletedAction(reportAction: OnyxInputOrEntry<ReportAction | OptimisticIOUReportAction>): boolean {
	const message = reportAction?.message ?? [];
	if (!Array.isArray(message)) {
	return message?.html === '' || !!message?.deleted;
	}
	// A legacy deleted comment has either an empty array or an object with html field with empty string as value
	const isLegacyDeletedComment = message.length === 0 || message.at(0)?.html === '';
	return isLegacyDeletedComment || !!message.at(0)?.deleted;
	}

API Details

What changes do you think we should make in order to solve the problem?

We can update the condition in the shouldReportActionBeVisible to check if reportAction.actionName=CONST.REPORT.ACTIONS.TYPE.MANAGER_DETACH_RECEIPT to the action is visible.

!isDeleted || isPending || isDeletedParentAction(reportAction) || isReversedTransaction(reportAction) || reportAction.actionName=CONST.REPORT.ACTIONS.TYPE.MANAGER_DETACH_RECEIPT

Alternatively, we can update here to minimize the risk of regression.

App/src/pages/home/report/ReportActionsView.tsx

Line 259 in 94ab9cd

ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction),

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

• Fix the issue on the backend to return the correct message
• Add message value with the expected data to successData

  • App/src/pages/home/report/ReportActionsView.tsx

    Line 259 in 94ab9cd

    ReportActionsUtils.shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction),

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021867401523775541525

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[rushatgabhane]

seems like a backend issue to me 🎀👀🎀

but it looks like we can do it on frontend too? #53998 (comment)