[HOLD for payment 2025-01-02] [$250] Workspace - Members invited in offline are not shown in approval page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9. 0.74-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): N
Issue reported by: Applause Internal Team

Action Performed:

1. Launch app
2. Go to workspace settings
3. Tap more features -- enable workflow
4. Tap workflow - enable approval flow
5. Tap add approval workflow and enable it
6. Go to members page
7. Go offline
8. Invite a member
9. Tap workflow - add approval workflow

Expected Result:

Members invited in offline must be shown in approval page.

Actual Result:

Members invited in offline are not shown in approval page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6690716_1733907244827.Screenrecorder-2024-12-11-14-13-55-341_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866908681014761163
• Upwork Job ID: 1866908681014761163
• Last Price Increase: 2024-12-11

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The invited member while offline doesn't show in workflow approval list.

What is the root cause of that problem?

We get the list from the policy employeeList, but we return early if the member doesn't have either email or submitsTo property.

App/src/libs/WorkflowUtils.ts

Lines 117 to 122 in 8749259

	Object.values(employees).forEach((employee) => {
	const {email, submitsTo, pendingAction} = employee;
	if (!email || !submitsTo) {
	return;
	}

This is because we don't add those optimistically.

App/src/libs/actions/Policy/Member.ts

Line 630 in 8749259

optimisticMembersState[email] = {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, role: CONST.POLICY.ROLE.USER};

What changes do you think we should make in order to solve the problem?

We can add both email and submitsTo optimistically. The submitsTo of a new user will default to the default approver.

optimisticMembersState[email] = {email, pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD, role: CONST.POLICY.ROLE.USER, submitsTo: PolicyUtils.getDefaultApprover(allPolicies?.[policyKey])};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can create a test for addMembersToWorkspace to make sure the optimistic data is correctly added when adding a new member.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866908681014761163

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[jjcoffee]

@bernhardoj's proposal LGTM!

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.