[HOLD for payment 2024-12-20] [HOLD for payment 2024-12-19] [$250] Search - Approve button becomes green when the held expense is selected via checkbox

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 53889
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Add approvals feature is enabled.
• Admin is the approver.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense.
4. Go to transaction thread.
5. Click on the report header > Hold > Hold the expense.
6. Go to Search.
7. Note that Approve button is gray.
8. Select the expense via checkbox.

Expected Result:

Approve button should remain gray as long as the expense is held.

Actual Result:

Approve button becomes green when the held expense is selected via checkbox.
It turns gray when hovered in selected state.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6690430_1733874805350.hold_search.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866771543910403509
• Upwork Job ID: 1866771543910403509
• Last Price Increase: 2024-12-11

Issue Owner

Current Issue Owner: @jayeshmangwani

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Approve button becomes green when the held expense is selected via checkbox.
It turns gray when hovered in selected state.

What is the root cause of that problem?

We are setting button style with styles.buttonSuccessHovered if this row is selected here

App/src/components/SelectionList/Search/ActionCell.tsx

Line 95 in dac90e1

const buttonInnerStyles = isSelected ? styles.buttonSuccessHovered : {};

even though we have set shouldUseSuccessStyle to false if isOnHold here

App/src/components/SelectionList/Search/TransactionListItemRow.tsx

Line 283 in dac90e1

shouldUseSuccessStyle={!isOnHold}

What changes do you think we should make in order to solve the problem?

We should update this condition to show style buttonSuccessHovered when shouldUseSuccessStyle as true

    const buttonInnerStyles = isSelected && shouldUseSuccessStyle ? styles.buttonSuccessHovered : {};

App/src/components/SelectionList/Search/ActionCell.tsx

Line 95 in dac90e1

const buttonInnerStyles = isSelected ? styles.buttonSuccessHovered : {};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.