[HOLD for payment 2025-01-17] [$250] Copilot not correctly displayed in report action

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.73-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @heyjennahay
Slack conversation (hyperlinked to channel name): expensify_expense

Action Performed:

1. User A creates a workspace, turns on approvals
2. User A adds a Copilot (User C)
3. User A invites User B to the workspace (User B has never interacted with Copilot)
4. User B submits an expense report, and logs out
5. Copilot copilots into User A's account and approves the report
6. User B logs back in and views the report

Expected Result:

User C on the behalf of User A approved the report as action message

Actual Result:

User C on behalf of User C approved the report as action message.

While reproducing observed this: On hovering over a username, the tooltip displays the text:
"User C (as copilot for User C)"

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021869141076979307076
• Upwork Job ID: 1869141076979307076
• Last Price Increase: 2024-12-17
• Automatic offers:
• nkdengineer | Contributor | 105389296

Issue Owner

Current Issue Owner: @dukenv0307

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ChavdaSachin]

Edited by proposal-police: This proposal was edited at 2024-12-10 20:49:32 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

wrong Account IDs being passed here.

App/src/pages/home/report/ReportActionItemSingle.tsx

Line 218 in fca45c9

accountID={Number(icon.id ?? -1)}

App/src/pages/home/report/ReportActionItemSingle.tsx

Line 269 in fca45c9

accountID={Number(icon.id) ?? -1}

Because icon.id also would contain delegator account id if action is performed by a delegator from here.

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 111 to 114 in fca45c9

	} else if (action?.delegateAccountID && personalDetails[action?.delegateAccountID]) {
	displayName = delegatePersonalDetails?.displayName ?? '';
	avatarSource = delegatePersonalDetails?.avatar;
	avatarId = delegatePersonalDetails?.accountID;

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 154 to 159 in fca45c9

	const icon = {
	source: avatarSource ?? FallbackAvatar,
	type: isWorkspaceActor ? CONST.ICON_TYPE_WORKSPACE : CONST.ICON_TYPE_AVATAR,
	name: primaryDisplayName ?? '',
	id: avatarId,
	};

What changes do you think we should make in order to solve the problem?

pass accountID={Number(action?.actorAccountID ?? -1)} at both places.

App/src/pages/home/report/ReportActionItemSingle.tsx

Line 218 in fca45c9

accountID={Number(icon.id ?? -1)}

App/src/pages/home/report/ReportActionItemSingle.tsx

Line 269 in fca45c9

accountID={Number(icon.id) ?? -1}

We would also need to add delegateAccountID prop to component, and render on behalf of delegate... tooltip wherever needed.

Specifics could be discussed during PR.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Mostly doesn't need any test for such small ui change, but it could be added in case

What alternative solutions did you explore? (Optional)

Alternatively modify icon object to contain both actorAccountID and delegateAccountID, and modify to read those IDs from icon prop, this will solve both single icon and multiple icon issue.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-12-18 10:17:17 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User C on behalf of User C approved the report as action message.

What is the root cause of that problem?

By default, the icon.id is the default user (it's userA in this case) and it's changed to delegateAccountID if the user has personal details of the delegate account.

1. The user B doesn't have the personal details of user C then icon.id is the userA

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 111 to 115 in fca45c9

	} else if (action?.delegateAccountID && personalDetails[action?.delegateAccountID]) {
	displayName = delegatePersonalDetails?.displayName ?? '';
	avatarSource = delegatePersonalDetails?.avatar;
	avatarId = delegatePersonalDetails?.accountID;
	} else if (isReportPreviewAction && isTripRoom) {

App/src/pages/home/report/ReportActionItemSingle.tsx

Line 218 in fca45c9

accountID={Number(icon.id ?? -1)}

2. The user A has the personal details of user C then icon?.id and action?.delegateAccountID are the same

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 218 to 220 in fca45c9

	accountID={Number(icon.id ?? -1)}
	delegateAccountID={Number(action?.delegateAccountID ?? -1)}
	icon={icon}

What changes do you think we should make in order to solve the problem?

1. We should only display the onBehalfOfMessage if delegatePersonalDetails exists.

{!!action?.delegateAccountID && !isReportPreviewAction && !!delegatePersonalDetails && (
    <Text style={[styles.chatDelegateMessage]}>{translate('delegate.onBehalfOfMessage', {delegator: accountOwnerDetails?.displayName ?? ''})}</Text>
)}

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 289 to 291 in fca45c9

	{!!action?.delegateAccountID && !isReportPreviewAction && (
	<Text style={[styles.chatDelegateMessage]}>{translate('delegate.onBehalfOfMessage', {delegator: accountOwnerDetails?.displayName ?? ''})}</Text>
	)}

2. If action?.delegateAccountID && personalDetails[action?.delegateAccountID] is true, here we should pass accountID as actorAccountID. If we always use actorAccountID that can cause the avatar is display wrongly.

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 218 to 220 in fca45c9

	accountID={Number(icon.id ?? -1)}
	delegateAccountID={Number(action?.delegateAccountID ?? -1)}
	icon={icon}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

If we want to display the fallback avatar and the delegate email, here we can remove personalDetails[action?.delegateAccountID], fallback displayName to action.originalMessage.delegate and avatarId to action?. delegateAccountID

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 111 to 115 in fca45c9

	} else if (action?.delegateAccountID && personalDetails[action?.delegateAccountID]) {
	displayName = delegatePersonalDetails?.displayName ?? '';
	avatarSource = delegatePersonalDetails?.avatar;
	avatarId = delegatePersonalDetails?.accountID;
	} else if (isReportPreviewAction && isTripRoom) {

Then here, we will not display the tooltip for this issue because we don't have personal detail of delegate account

App/src/pages/home/report/ReportActionItemSingle.tsx

Line 216 in fca45c9

return (

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021869141076979307076