[$250] Android - Inbox - WS filters are not reset to "All Chats" when deleting actual workspace.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.73-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+86@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Open the Expensify app.
2. Tap on the workspace switcher on the top left corner.
3. Select any workspace.
4. Tap on "Settings" and select "Workspaces"
5. Tap on the three dots icon on the selected workspace.
6. Delete the workspace.
7. Return to inbox using the device back button.
8. Verify that inbox section is not filtered by the selected workspace anymore and all the chats are displayed.

Expected Result:

When deleting the actual workspace, inbox section should return to "All Chats" mode again.

Actual Result:

After deleting actual workspace and returning to inbox using device back button, chats are still filtered by workspace and are not reseted to "All Chats" mode.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6690201_1733850647051.WS_Filters.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021869052011810427221
• Upwork Job ID: 1869052011810427221
• Last Price Increase: 2025-01-07

Issue Owner

Current Issue Owner: @abdulrahuman5196

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The home LHN doesn't reset to All chats when deleting the selected workspace from workspace switcher page.

What is the root cause of that problem?

When we delete the workspace, it will call switchPolicyID which pushes a new bottom tab screen, in this case, the Settings, with the policyID param removed.

App/src/libs/Navigation/switchPolicyID.ts

Lines 47 to 73 in f8f12c2

	if (name === SCREENS.SEARCH.CENTRAL_PANE) {
	name = SCREENS.SEARCH.BOTTOM_TAB;
	} else if (!params) {
	params = {policyID};
	} else {
	params.policyID = policyID;
	}
	// If the last route in the BottomTabNavigator is already a 'Home' route, we want to change the params rather than pushing a new 'Home' route,
	// so that the screen does not get re-mounted. This would cause an empty screen/white flash when navigating back from the workspace switcher.
	const homeRoute = bottomTabNavigatorRoute.state.routes.at(-1);
	if (homeRoute && homeRoute.name === SCREENS.HOME) {
	return {
	...CommonActions.setParams(params),
	source: homeRoute?.key,
	};
	}
	// If there is no 'Home' route in the BottomTabNavigator or if we are updating a different navigator, we want to push a new route.
	return {
	type: CONST.NAVIGATION.ACTION_TYPE.PUSH,
	payload: {
	name,
	params,
	},
	target: bottomTabNavigatorRoute.state.key,
	};

[Home, Home (policyA), Settings (policyA)] -> [Home, Home (policyA), Settings (policyA), Settings]

So, the LHN (Home) with the filtered workspace is still in the stack. Also, that's why we need to go back twice from settings, but it's a different issue to discuss. When we go back, we simply pop the screen until we arrive at the LHN with the filtered workspace.

We already have a solution to handle this case, which was added by this PR: #45285, that is by removing the policyID from the LHN (home) when the workspace is missing.

App/src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.tsx

Lines 32 to 52 in f8f12c2

	useEffect(() => {
	// Whether the active workspace or the "Everything" page is loaded
	const isWorkspaceOrEverythingLoaded = !!activeWorkspace || activeWorkspaceID === undefined;
	// If we are currently switching workspaces, we don't want to do anything until the target workspace is loaded
	if (isSwitchingWorkspace.current) {
	if (isWorkspaceOrEverythingLoaded) {
	isSwitchingWorkspace.current = false;
	}
	return;
	}
	// Otherwise, if the workspace is already loaded, we don't need to do anything
	if (isWorkspaceOrEverythingLoaded) {
	return;
	}
	isSwitchingWorkspace.current = true;
	Navigation.navigateWithSwitchPolicyID({policyID: undefined});
	updateLastAccessedWorkspace(undefined);
	}, [activeWorkspace, activeWorkspaceID]);

The problem is, after deleting the workspace, the workspace data still exists on the onyx with this information that is returned by the BE.

What changes do you think we should make in order to solve the problem?

To fix it, we can check for the workspace/policy type.

App/src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.tsx

Line 34 in f8f12c2

const isWorkspaceOrEverythingLoaded = !!activeWorkspace || activeWorkspaceID === undefined;

const isWorkspaceOrEverythingLoaded = !!activeWorkspace?.type || activeWorkspaceID === undefined;

or use shouldShowPolicy

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

@abekkala Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021869052011810427221

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)