-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[HOLD for payment 2025-02-07] [Performance] Create PING for Pusher Connection #53826
Copy link
Copy link
Closed
Labels
AutoAssignerNewDotQualityUsed to assign quality issues to engineersUsed to assign quality issues to engineersAwaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Description
Metadata
Metadata
Assignees
Labels
AutoAssignerNewDotQualityUsed to assign quality issues to engineersUsed to assign quality issues to engineersAwaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
StatusShow more project fields
Done
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
What performance issue do we need to solve?
Intermittently, Pusher becomes unreachable for reasons out of our control and the client needs to reconnect to it, which causes delays or failure to get realtime updates to chat data.
We can't count on Pusher's internal PING to detect liveness -- we need our own application layer Pusher-ping.
What is the impact of this on end-users?
A more reliable Pusher-PING means users get realtime updates to their New Expensify data more reliably.
List any benchmarks that show the severity of the issue
This is a recurring issue: https://expensify.slack.com/archives/C05LX9D6E07/p1731299637345689
Proposed solution (if any)
Develop our own application layer Pusher-PING that works in the same way as our existing PING code, but instead tests the Pusher connection.
List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)
Note: These should be the same as the benchmarks collected before any changes.
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1731299637345689
View all open jobs on Upwork
Issue Owner
Current Issue Owner: @mallenexpensify