[HOLD for payment 2024-12-19] [HOLD for payment 2024-12-17] Expense - "Go to workspace" option is available when the workspace is deleted

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.73-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+23i0230@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace
3. Go to workspace chat
4. Submit an expense
5. Delete the workspace
6. Go back to workspace chat (now archived)
7. Click on the expense preview
8. Click on the report header
9. Click Go to workspace

Expected Result:

"Go to workspace" option should be removed when the workspace is deleted

Actual Result:

"Go to workspace" option is available when the workspace is deleted, which opens not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6689091_1733764302609.go_workspace_.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Shahidullah-Muffakir]

Edited by proposal-police: This proposal was edited at 2024-12-09 18:02:03 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Go to workspace" option is available when the workspace is deleted

What is the root cause of that problem?

this does not consider deleted workspace:

App/src/pages/ReportDetailsPage.tsx

Line 294 in dc07fc6

const shouldShowGoToWorkspace = policy && policy.type !== CONST.POLICY.TYPE.PERSONAL && policy.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;

What changes do you think we should make in order to solve the problem?

Update this condition to ensure that the "Go to workspace" option is hidden when the workspace is deleted(archived).
we can use !!PolicyUtils.getPolicyRole(policy, currentUserLogin) for it, as we use this in other parts of the app.

App/src/pages/ReportDetailsPage.tsx

Line 294 in dc07fc6

const shouldShowGoToWorkspace = policy && policy.type !== CONST.POLICY.TYPE.PERSONAL && policy.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;

const shouldShowGoToWorkspace = policy && policy.type !== CONST.POLICY.TYPE.PERSONAL && policy.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && !!PolicyUtils.getPolicyRole(policy, currentUserLogin);

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-12-09 18:00:51 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Go to workspace" option is available when the workspace is deleted, which opens not here page

What is the root cause of that problem?

We do not check the archived rooms in condition to show go to workspace here

App/src/pages/ReportDetailsPage.tsx

Line 294 in dc07fc6

const shouldShowGoToWorkspace = policy && policy.type !== CONST.POLICY.TYPE.PERSONAL && policy.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;

What changes do you think we should make in order to solve the problem?

We should add logic to check the archived rooms like we did with show hold option

const shouldShowGoToWorkspace = policy && policy.type !== CONST.POLICY.TYPE.PERSONAL && policy.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && !isArchivedRoom

App/src/pages/ReportDetailsPage.tsx

Line 294 in dc07fc6

const shouldShowGoToWorkspace = policy && policy.type !== CONST.POLICY.TYPE.PERSONAL && policy.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mkzie2]

It's a backend bug, after the policy is deleted, the backend still returns the policy data. But after clear cache and restart, this data doesn't exist.

[deetergp]

Related to #53076