[HOLD for payment 2025-01-17] [HOLD for payment 2025-01-02] [$250] Login - here link in suspended account message is invalid

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ojidojdmwowjdoj@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a suspended account (ojidojdmwowjdoj@gmail.com).
3. Click here link.

Expected Result:

The link will open a relevant site.

Actual Result:

The link is invalid and opens error page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021866332376780918197
• Upwork Job ID: 1866332376780918197
• Last Price Increase: 2024-12-10
• Automatic offers:
• allgandalf | Reviewer | 105357072
• truph01 | Contributor | 105357074

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login - here link in suspended account message is invalid

What is the root cause of that problem?

The link used to point to community.expensify.com discussion, but since we now are move to help.expensify.com, we need to update the link.

What changes do you think we should make in order to solve the problem?

We will change the link here:

App/src/pages/signin/EmailDeliveryFailurePage.tsx

Line 56 in 840c227

href="https://community.expensify.com/discussion/5651/deep-dive-best-practices-when-youre-running-into-trouble-receiving-emails-from-expensify/p1?new=1"

We should maybe point it to the Email-Notifications.md page 🤔 or as the team decides.

[melvin-bot]

@alexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• When the user click on 'authenticator app link' the redirected website throws an error

What is the root cause of that problem?

• When open the link to here text, the below link will be opened:
  

  App/src/pages/signin/EmailDeliveryFailurePage.tsx

  Line 56 in 840c227

  href="https://community.expensify.com/discussion/5651/deep-dive-best-practices-when-youre-running-into-trouble-receiving-emails-from-expensify/p1?new=1"

• In PR, we already have a logic to redirect app to https://help.expensify.com/articles/expensify-classic/settings/account-settings/Set-Notifications (targetURL) in case of https://community.expensify.com/discussion/5651/deep-dive--practices-when-youre-running-into-trouble-receiving-emails-from-expensify (sourceURL):

App/docs/redirects.csv

Line 388 in 66cf824

https://community.expensify.com/discussion/5651/deep-dive--practices-when-youre-running-into-trouble-receiving-emails-from-expensify,https://help.expensify.com/articles/expensify-classic/settings/account-settings/Set-Notifications

but there are a few problem with that link:

1. In here, the sourceURL is ...deep-dive--practices...: It is a typo issue, it should be ...deep-dive-best-practices....
2. In here, the sourceURL does not contain /p1?new=1, but the link in here does.

Both of the above reasons leads to our current bug, where the here link is not equal to the sourceURL link in the sourceURL-targetURL pair.

What changes do you think we should make in order to solve the problem?

• We should update the link in line:
  

  App/src/pages/signin/EmailDeliveryFailurePage.tsx

  Line 56 in 840c227

  href="https://community.expensify.com/discussion/5651/deep-dive-best-practices-when-youre-running-into-trouble-receiving-emails-from-expensify/p1?new=1"

  directly:

                            href="https://help.expensify.com/articles/expensify-classic/settings/account-settings/Set-Notifications"

What alternative solutions did you explore? (Optional)

• We need to move the link here to the CONST:

SET_NOTIFICATION_LINK  =  "https://community.expensify.com/discussion/5651/deep-dive--practices-when-youre-running-into-trouble-receiving-emails-from-expensify"

and then use it as href={SET_NOTIFICATION_LINK}

• Finally, update the csv file to fix 2 errors i mentioned in RCA section to make sure the SET_NOTIFICATION_LINK is equal to the sourceURL in:

App/docs/redirects.csv

Line 388 in 66cf824

https://community.expensify.com/discussion/5651/deep-dive--practices-when-youre-running-into-trouble-receiving-emails-from-expensify,https://help.expensify.com/articles/expensify-classic/settings/account-settings/Set-Notifications

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021866332376780918197

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)