[HOLD for payment 2024-12-19] Refactor buildOnyxDataForMoneyRequest to use a parameter object

[neil-marcellini]

As part of the tracking issue, and as advised in its description, refactor buildOnyxDataForMoneyRequest to use a parameter object.

Issue Owner

Current Issue Owner: @hungvu193

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-12-09 20:14:37 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Refactor createDistanceRequest to use a parameter

What is the root cause of that problem?

This is an improvement

What changes do you think we should make in order to solve the problem?

Wrap all parameters of this function into one object and in this object, we can have some sub-objects that will wrap the related data.

App/src/libs/actions/IOU.ts

Line 5310 in 4f4720e

function createDistanceRequest(

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[mkzie2]

@neil-marcellini I'm here.

[neil-marcellini]

@dukenv0307 is doing C+ for all these