[HOLD for payment 2025-01-02] [$250] Invite - Two same QA guides in the member list after onboarding with Manage my team's expenses

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Sign up with a new Gmail account (random email without +)
3. On onboarding purpose, choose Manage my team's expenses
4. Select organization size
5. Select an accounting
6. Complete the onboarding
7. Go to workspace settings > Members
8. Click Invite member

Expected Result:

There will be only one QA guide in the member list

Actual Result:

There are two same QA guides in the member list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6684422_1733328208888.bandicam_2024-12-04_23-57-41-348.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021864467241309755517
• Upwork Job ID: 1864467241309755517
• Last Price Increase: 2024-12-05
• Automatic offers:
• ikevin127 | Contributor | 105288097

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jliexpensify]

I can repro on Hybrid App Android and have had a colleague repro on Safari:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021864467241309755517

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[jliexpensify]

@dukenv0307 - I'm pretty sure this might be Internal, but let me know what you think!

[ikevin127]

Proposal

Please re-state the problem that we are trying to solve in this issue

There are two of the same QA guides in the suggested members list.

What is the root cause of that problem?

Note

I was not able to reproduce the issue, on my side it always showed 1 guide from the Expensify team, it never showed qa.guide@team.expensify.com.

I'm not sure of the exact steps required for this to be consistently reproduced, or why the BE (I assume) sends the same value twice in some instances.

I remember similar issues in the past where personalDetailsList was populated with duplicates.

The root cause of why the list can have two of the same values comes from here:

App/src/pages/workspace/WorkspaceInvitePage.tsx

Lines 190 to 196 in 0e28aa4

	const personalDetailsFormatted = personalDetailsWithoutSelected.map((item) => OptionsListUtils.formatMemberForList(item));
	sectionsArr.push({
	title: translate('common.contacts'),
	data: personalDetailsFormatted,
	shouldShow: !isEmptyObject(personalDetailsFormatted),
	});

because personalDetailsFormatted doesn't have any logic to handle duplicates.

What changes do you think we should make in order to solve the problem?

This is how objects of personalDetailsFormatted (array) look if we log the array:

{
    accountID: 2746397
    alternateText: "zach@expensify.com"
    icons: [Object] (1)
    isDisabled: false
    isSelected: false
    keyForList: "2746397"
    login: "zach@expensify.com"
    pendingAction: undefined
    reportID: ""
    text: "Zach Greenwald (EXFY Product Manager)"
}

Given this and knowing that we use login as unique identifier across the app, we can add the following filtering logic to personalDetailsFormatted to ensure we won't have duplicated entries in the edge case where BE happens to populate personalDetailsList with duplicated values.

const personalDetailsFormatted = personalDetailsFormatted
    .concat(personalDetailsFormatted)
    .filter((item, index, array) => item?.login && index === array.findIndex((i) => i.login === item.login));

Before	After

[dukenv0307]

@jliexpensify I also can't reproduce. Can you share your personalDetailsList?