Auto-fill company website using user's domain, remove https:// requirement

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Problem

The company website field must lead with https:// , otherwise the step will return an error. While we auto-populate the company website field with this, a user can easily delete it and be left with a confusing error.

Action Performed:

1. Create workspace
2. Go through VBA flow to Company Information step
3. Delete part of https//: and enter a website
4. Try to submit the form

Solution

1. Remove the https//: format requirement from the code
2. auto-fill the Company website with the user's domain and allow this to be editable (i.e. www.domain.com)

Let's make https//: non-editable in the company website field, so that a user cannot delete it. Going to tap @Expensify/design on this first before we pass it off for implementation.

Platform:

• Web
• iOS
• Android
• Desktop App
• Mobile Web

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @JmillsExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[marcaaron]

Forcing https:// to be uneditable sounds a little complicated to me + assumes everyone uses https which is false for a surprising number of websites.

I think a third alternative solution would be to:

• Just allow urls without the protocol to pass the validation e.g. test.com instead of http://test.com
• Just append an http:// (not https://) to any urls that are missing the protocol when submitting the form

[kevinksullivan]

Let's hold off until we figure out why we're requiring this in the first place.

[JmillsExpensify]

Ok so coming back to this one, I kinda wonder if we should instead be following a different route entirely. Basically, for any user that goes down the VBA flow:

• If the user's primary login is a private domain, then don't show them the website field. Instead, parse out the lastPart of their email and store their domain for Stripe's website parameter.
• If the user's primary login is a public domain, show then allow the URLs without the protocol to pass the validation e.g. test.com

What do ya'll think?

[marcaaron]

allow the URLs without the protocol to pass the validation e.g. test.com

I think starting with this makes sense. Unsure about the first bullet. What if instead of hiding the field completely we just pre-populate it with their domain from their email if it's a private domain?

[JmillsExpensify]

Nice yeah that's a really good call. You're right, that is better.