[HOLD for payment 2021-09-28] Add an Edit Icon to Workspace Avatar

[MitchExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Problem:

It is not obvious that a workspace name and icon can be edited by clicking the workspace avatar in the workspace configuration screen:

Solution:

Add an Edit Icon to Workspace Avatar like we do on the Edit Workspace screen:

View all open jobs on GitHub

Internal: Slack discussion

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MitchExpensify]

This is an existing pattern that can be copied exactly. Its also a straightforward change that doesn't need Triaging. Labelling external and removing triage assignment.

[parasharrajat]

Proposal

1. We already have everything set up correctly. We just need to add the static Icon.
   we will add a new sibling icon here

   App/src/pages/workspace/WorkspaceSidebar.js

   Line 108 in f20deb8

   <Pressable

								<View
                                    style={[styles.smallEditIcon, styles.smallAvatarEditIcon]}
                                >
                                    <Icon
                                        src={Pencil}
                                        width={variables.iconSizeSmall}
                                        height={variables.iconSizeSmall}
                                        fill={themedefault.iconReversed}
                                    />
                                </View>

I don't prefer using the AvatarWithImagePicker as it contains a lot of unnecessary code such as AttachmentPicker etc.

2. With respect to the above, We can optionally add a Tooltip indicating Edit Workspace. (Please confirm if we want this).

[mountiny]

I can step into this as CME since we want to have this Polish done asap.

You are right @parasharrajat, we even had the pencil icon in there previously, but then decided to remove it. What a U-turn 😅

I like your proposal, it is simple and does what we need. Feel free to create a PR for this, however, bear in mind we will most likely create the Upwork job no sooner than on Monday and that is when we could hire you too. So I understand if you would not want/would not be able to work on this until then. Thank you for taking this on! 🙇

Regarding the tooltip, could you please provide a screenshot of how it could look like? cc @trjExpensify would you want to add a tooltip as well (ccing you since you brought up this issue). Thank you 🙌

[MitchExpensify]

Upwork job