[HOLD for payment 2024-12-17] [$250] Attachments - Attachment preview slides to the right with a delay when dismissed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.65-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5249444
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch staging new.expensify Hybrid app and sign in
2. Open 1:1 chat with variety of attachments sent
3. Tap on attachment preview to open larger preview
4. Tap < button on the left side of the preview to navigate back to the chat
5. Repeat with a few other attachments

Expected Result:

Attachment preview can be dismissed without delay

Actual Result:

Attachment preview slides to the right with a delay when dismissed. Part of the current attachment followed by previously opened attachment can be seen for a couple of seconds on the right side of the screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6672381_1732225868220.Back_from_preview.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021859724558833397121
• Upwork Job ID: 1859724558833397121
• Last Price Increase: 2024-11-21
• Automatic offers:
• huult | Contributor | 105065706

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[trjExpensify]

I can repro this:

ScreenRecording_11-21-2024.22-22-54_1.MP4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021859724558833397121

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[huult]

Edited by proposal-police: This proposal was edited at 2024-11-22 07:32:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Attachment preview slides to the right with a delay when dismissed

What is the root cause of that problem?

The modal dismissal was triggered before the attachment carousel animation completed. This caused a conflict between the animation lifecycle and modal dismissal, leading to visual inconsistencies.

App/src/pages/home/report/ReportAttachments.tsx

Line 54 in 5e2d95a

Navigation.dismissModal();

App/src/components/Attachments/AttachmentCarousel/index.tsx

Line 294 in f5e8d3e

<Animated.FlatList

This happens only on iOS native because its native modal animations run concurrently with Animated.FlatList, leading to conflicts. iOS enforces stricter rendering and animation synchronization, exposing timing issues.

What changes do you think we should make in order to solve the problem?

To resolve this issue, we must delay dismissing the modal until the animation of the attachment carousel is completed. This ensures that all active interactions, including animations and gestures, are finished before the modal is dismissed, avoiding conflicts between the animation lifecycle and modal dismissal. Something like this:

//src/pages/home/report/ReportAttachments.tsx#L55
       <AttachmentModal
            accountID={Number(accountID)}
            type={type}
            allowDownload
            defaultOpen
            report={report}
            source={source}
            onModalClose={() => {
+                InteractionManager.runAfterInteractions(() => {
+                    requestAnimationFrame(() => {
                        Navigation.dismissModal();
                        // This enables Composer refocus when the attachments modal is closed by the browser navigation
                        ComposerFocusManager.setReadyToFocus();
+                    });
+                });
            }}
            onCarouselAttachmentChange={onCarouselAttachmentChange}
            shouldShowNotFoundPage={!isLoadingApp && type !== CONST.ATTACHMENT_TYPE.SEARCH && !report?.reportID}
            isAuthTokenRequired={!!isAuthTokenRequired}
            attachmentLink={attachmentLink ?? ''}
            originalFileName={fileName ?? ''}
        />

Note: We can write this code specifically for iOS using Platform.OS === 'ios' or by creating an index.ios.ts file. We will discuss and implement this approach during the PR phase

POC

Screen.Recording.2024-11-22.at.14.14.51.mov

What alternative solutions did you explore? (Optional)

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Attachment preview slides to the right with a delay when dismissed. Part of the current attachment followed by previously opened attachment can be seen for a couple of seconds on the right side of the screen

What is the root cause of that problem?

When pressing back button:

App/src/pages/home/report/ReportAttachments.tsx

Lines 53 to 57 in 056e8ee

	onModalClose={() => {
	Navigation.dismissModal();
	// This enables Composer refocus when the attachments modal is closed by the browser navigation
	ComposerFocusManager.setReadyToFocus();
	}}

AttachmentModal is closed before AttachmentCarousel finishes unmounting, which causes visual bug.

The same bug appears on TransactionReceiptPage as well:

Screen.Recording.2024-11-22.at.15.59.14.mov

What changes do you think we should make in order to solve the problem?

Wrap onModalClose function with InteractionManager.runAfterInteractions:

App/src/pages/home/report/ReportAttachments.tsx

Lines 53 to 57 in 056e8ee

	onModalClose={() => {
	Navigation.dismissModal();
	// This enables Composer refocus when the attachments modal is closed by the browser navigation
	ComposerFocusManager.setReadyToFocus();
	}}

            onModalClose={() => {
                InteractionManager.runAfterInteractions(() => {
                    Navigation.dismissModal();
                    // This enables Composer refocus when the attachments modal is closed by the browser navigation
                    ComposerFocusManager.setReadyToFocus();
                });
            }}

Apply the same for TransactionReceiptPage as well:

App/src/pages/TransactionReceiptPage.tsx

Line 78 in 056e8ee

onModalClose={onModalClose}

            onModalClose={() => {
                InteractionManager.runAfterInteractions(() => {
                    onModalClose();
                });
            }}

What alternative solutions did you explore? (Optional)

[thesahindia]

@huult's proposal is first but @daledah's proposal is also fixing another similar case. I will leave the decision to the engineer on this.

🎀 👀 🎀 C+ reviewed