[Due for payment 2025-03-17] [$500] Desktop - Scan receipts - There is a delay after clicking the submit expense button

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.63-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5231836&group_by=cases:section_id&group_id=294998&group_order=asc
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to the workspace chat as the employee
2. Select the option to Submit expense > Scan receipt
3. Select the option to upload a receipt
4. Upload a receipt file
5. Click the "Submit expense" button

Expected Result:

The submitting expense flow using scanning option is smooth

Actual Result:

There is a delay after clicking the submit expense button

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6666749_1731706218416.scan_receipt.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021858847049782861721
• Upwork Job ID: 1858847049782861721
• Last Price Increase: 2025-01-03
• Automatic offers:
• wildan-m | Contributor | 106254364

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is a delay after clicking the submit expense button

What is the root cause of that problem?

In

App/desktop/main.ts

Lines 24 to 27 in 63c8dd2

	// Setup google api key in process environment, we are setting it this way intentionally. It is required by the
	// geolocation api (window.navigator.geolocation.getCurrentPosition) to work on desktop.
	// Source: https://github.com/electron/electron/blob/98cd16d336f512406eee3565be1cead86514db7b/docs/api/environment-variables.md#google_api_key
	process.env.GOOGLE_API_KEY = CONFIG.GCP_GEOLOCATION_API_KEY;

it mentioned that we need to provide the GCP_GEOLOCATION_API_KEY, but it's not available on desktop dev env or it can be expired on staging/production

What changes do you think we should make in order to solve the problem?

This issue happens if we don't provide GCP_GEOLOCATION_API_KEY, especially on dev env where we don't have it

If GCP_GEOLOCATION_API_KEY is undefined on desktop, we can skip navigator.geolocation.getCurrentPosition

on desktop.ts

CONFIG.GCP_GEOLOCATION_API_KEY;

const getCurrentPosition: GetCurrentPosition = (success, error, options) => {
    if (navigator === undefined || !('geolocation' in navigator) || !CONFIG.GCP_GEOLOCATION_API_KEY) {
...
return;
}

What alternative solutions did you explore? (Optional)

[zanyrenney]

Nice, looks like we also already have a proposal.

[zanyrenney]

Moving ahead here.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021858847049782861721

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)