[HOLD for payment 2025-01-13] [$250] Web - Thread - Switching to Search and back after clicking "Join thread" opens the report

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.61-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): testpayment935+613@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. (User A) Send any message to 1:1 conversation for the account you have access to
2. (User B) go to the new message from User A and open context menu
3. (User B) Click "Join Thread"
4. Navigating to Settings/Search and go to Inbox again

Expected Result:

The "Join Thread" option should not navigate to the report.

Actual Result:

"Join thread" option navigates to the report page after navigating to other bottom navigations like Search or Setting and returning back to inbox.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6663491_1731486430970.bandicam_2024-11-13_11-14-04-868.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021858763130278701100
• Upwork Job ID: 1858763130278701100
• Last Price Increase: 2024-12-03
• Automatic offers:
• mkzie2 | Contributor | 105221093

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-11-13 13:06:19 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Thread - Noting happen when clicking "Join thread" button unless returning to inbox again

What is the root cause of that problem?

When we press the join button openReport is called with new child report id here

App/src/libs/actions/Report.ts

Line 1871 in 4d9be4e

openReport(newChat.reportID, '', participantLogins, newChat, parentReportAction.reportActionID);

and that will set the visitedTime of the child report to the current time

App/src/libs/actions/Report.ts

Line 832 in 084a711

lastVisitTime: DateUtils.getDBTime(),

so when we navigate back to the inbox the empty child report will be opened as it is the last accessed report according to its visitedTime

What changes do you think we should make in order to solve the problem?

We should not set the lastVisitedTime for the child report on join as we are not visiting it only subscribing to it. So:

add optional shouldSetVisitedTime param for openReport

shouldSetVisitedTime = true,

App/src/libs/actions/Report.ts

Line 832 in 084a711

lastVisitTime: DateUtils.getDBTime(),

                ...(shouldSetVisitedTime && {lastVisitTime: DateUtils.getDBTime()}),

and pass as false for open reports in join thread for both when the childReport exists or not

App/src/libs/actions/Report.ts

Line 1900 in 084a711

openReport(childReportID);

        openReport(childReportID, undefined, undefined, undefined, undefined, undefined, undefined, undefined, false);

App/src/libs/actions/Report.ts

Line 1926 in 084a711

openReport(newChat.reportID, '', participantLogins, newChat, parentReportAction.reportActionID);

        openReport(newChat.reportID, '', participantLogins, newChat, parentReportAction.reportActionID, false);

What alternative solutions did you explore? (Optional)

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-11-19 08:56:27 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Join thread" option navigating to "reply in thread" page after navigating to other bottom navigations like Search or Setting and returning back to inbox

What is the root cause of that problem?

• Firstly, we need to explain why the join thread option is only shown in non-thread actions of other user

The difference is here, if reportAction?.childReportNotificationPreference is undefined, getChildReportNotificationPreference function returns always if the user is the creator of the action, otherwise it returns hidden

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 305 in b1c1a4b

const childReportNotificationPreference = ReportUtils.getChildReportNotificationPreference(reportAction);

App/src/libs/ReportUtils.ts

Lines 1762 to 1768 in b1c1a4b

	function getChildReportNotificationPreference(reportAction: OnyxInputOrEntry<ReportAction> | Partial<ReportAction>): NotificationPreference {
	const childReportNotificationPreference = reportAction?.childReportNotificationPreference ?? '';
	if (childReportNotificationPreference) {
	return childReportNotificationPreference;
	}
	return isActionCreator(reportAction) ? CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS : CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN;

• When we click on Join thread, a new report is created and when we go back from search it is displayed as the last accessed report

App/src/libs/actions/Report.ts

Line 1843 in b1c1a4b

function toggleSubscribeToChildReport(childReportID = '-1', parentReportAction: Partial<ReportAction> = {}, parentReportID = '-1', prevNotificationPreference?: NotificationPreference) {

What changes do you think we should make in order to solve the problem?

I think the way we update lastVisitTime here is incorrect. It was added here. According to my understanding
, lastVisitTime saves the last time we opened a report (the report screen is focused).

App/src/libs/actions/Report.ts

Line 832 in f810ac6

lastVisitTime: DateUtils.getDBTime(),

Call openReport doesn't mean we navigate to this report and we handled in ReportScreen here to update lastVisitTime whenever the ReportScreen is focused so we can remove the wrong logic here

App/src/libs/actions/Report.ts

Line 832 in f810ac6

lastVisitTime: DateUtils.getDBTime(),

What alternative solutions did you explore? (Optional)

[stephanieelliott]

Agree this seems buggy, adding labels.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021858763130278701100