[HOLD for payment 2024-12-17] [$250] No popup to open desktop app for 'Try New Expensify' link

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.60-2
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #52255
Email or phone of affected tester (no customers): applausetester+bp2410d@app;ause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition: user is logged in OD.

1. OD: Go to Settings > Account
2. Click on Credit Card Import > Import Card/Bank
3. Click on Privacy at the bottom
4. Go back to OD
5. Click on 'Try New Expensify'

Expected Result:

User is redirected to NewDot application. Popup with suggestion to open desktop app appears.

Actual Result:

User is redirected to NewDot application. No popup with suggestion to open desktop app.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6662964_1731442109921.no_popup.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021859311638145427434
• Upwork Job ID: 1859311638145427434
• Last Price Increase: 2024-11-27

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no prompt to open in desktop app.

What is the root cause of that problem?

When we open ND from OD, the link will have a transition path. If it's a transition URL, the prompt will be pending by App.beginDeepLinkRedirectAfterTransition().

App/src/components/DeeplinkWrapper/index.website.tsx

Lines 19 to 31 in 67d7299

	function promptToOpenInDesktopApp(initialUrl = '') {
	// If the current url path is /transition..., meaning it was opened from oldDot, during this transition period:
	// 1. The user session may not exist, because sign-in has not been completed yet.
	// 2. There may be non-idempotent operations (e.g. create a new workspace), which obviously should not be executed again in the desktop app.
	// So we need to wait until after sign-in and navigation are complete before starting the deeplink redirect.
	if (Str.startsWith(window.location.pathname, Str.normalizeUrl(ROUTES.TRANSITION_BETWEEN_APPS))) {
	const params = new URLSearchParams(window.location.search);
	// If the user is redirected from the desktop app, don't prompt the user to open in desktop.
	if (params.get('referrer') === 'desktop') {
	return;
	}
	App.beginDeepLinkRedirectAfterTransition();
	} else {

beginDeepLinkRedirectAfterTransition will only resolved after signOnTransitionToFinishPromise promise is resolved.

App/src/libs/actions/App.ts

Lines 501 to 503 in 67d7299

	function beginDeepLinkRedirectAfterTransition(shouldAuthenticateWithCurrentAccount = true) {
	waitForSignOnTransitionToFinish().then(() => beginDeepLinkRedirect(shouldAuthenticateWithCurrentAccount));
	}

It will be resolved in setUpPoliciesAndNavigate.

App/src/libs/actions/App.ts

Lines 441 to 447 in 67d7299

	if (!isLoggingInAsNewUser && exitTo) {
	Navigation.waitForProtectedRoutes()
	.then(() => {
	Navigation.navigate(exitTo);
	})
	.then(endSignOnTransition);
	}

setUpPoliciesAndNavigate is called when the AuthScreen is mounted.

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Line 303 in 67d7299

App.setUpPoliciesAndNavigate(session);

But as seen from the code above, the promise is only resolved if exitTo param is not empty. Currently, the exitTo param from OD is empty. exitTo=. So, the promise is never resolved.

What changes do you think we should make in order to solve the problem?

Fix the OD to provide the exitTo

OR

I think we should set a fallback to the exitTo when calling navigate. If it's empty, we use HOME.

App/src/libs/actions/App.ts

Line 425 in 67d7299

const exitTo = url.searchParams.get('exitTo') as Route | null;

Then remove the check for exitTo.

App/src/libs/actions/App.ts

Line 441 in 67d7299

if (!isLoggingInAsNewUser && exitTo) {

App/src/libs/actions/App.ts

Lines 419 to 421 in 67d7299

	if (!session || !currentUrl?.includes('exitTo')) {
	return;
	}

Also, when the exitTo is empty, it will show infinite loading

It's because when we navigate to HOME, it won't go anywhere because we are already at HOME, but the transition page is still at the nav stack.

App/src/libs/actions/App.ts

Lines 441 to 446 in 67d7299

	if (!isLoggingInAsNewUser && exitTo) {
	Navigation.waitForProtectedRoutes()
	.then(() => {
	Navigation.navigate(exitTo);
	})
	.then(endSignOnTransition);

So, we need to call Navigation.goBack too, but only if exitTo is empty because when exitTo is available, we already popped it out from LogOutPreviousUserPage. (basically we have 2 places of handling transition)

App/src/pages/LogOutPreviousUserPage.tsx

Lines 77 to 87 in 67d7299

	// We don't want to navigate to the exitTo route when creating a new workspace from a deep link,
	// because we already handle creating the optimistic policy and navigating to it in App.setUpPoliciesAndNavigate,
	// which is already called when AuthScreens mounts.
	// For HybridApp we have separate logic to handle transitions.
	if (!NativeModules.HybridAppModule && exitTo && exitTo !== ROUTES.WORKSPACE_NEW && !isAccountLoading && !isLoggingInAsNewUser) {
	Navigation.isNavigationReady().then(() => {
	// remove this screen and navigate to exit route
	Navigation.goBack();
	Navigation.navigate(exitTo);
	});
	}

if (!isLoggingInAsNewUser) {
    Navigation.waitForProtectedRoutes()
        .then(() => {
            if (isTransitioning && !exitTo) {
                Navigation.goBack();
            }
            Navigation.navigate(exitTo);
        })
        .then(endSignOnTransition);
}

OR

We can immediately call endSignOnTransition when exitTo isn't available.

App/src/libs/actions/App.ts

Lines 419 to 421 in 67d7299

	if (!session || !currentUrl?.includes('exitTo')) {
	return;
	}

App/src/libs/actions/App.ts

Lines 441 to 447 in 67d7299

	if (!isLoggingInAsNewUser && exitTo) {
	Navigation.waitForProtectedRoutes()
	.then(() => {
	Navigation.navigate(exitTo);
	})
	.then(endSignOnTransition);
	}

if (!session || !currentUrl?.includes('exitTo')) {
    endSignOnTransition();
    return;
}

if (!isLoggingInAsNewUser && exitTo) {
    Navigation.waitForProtectedRoutes()
        .then(() => {
            Navigation.navigate(exitTo);
        })
        .then(endSignOnTransition);
} else {
    endSignOnTransition();
}

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021859311638145427434

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)